Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 2/2] gdb: Don't skip prologue for explicit line breakpoints in assembler
Date: Wed, 03 Jul 2019 22:13:00 -0000	[thread overview]
Message-ID: <b474d566-32bf-98d1-de1c-ac41c03b56ac@redhat.com> (raw)
In-Reply-To: <95293b54fddd6327ba75d1d69ce7c2118c02cb70.1562003938.git.andrew.burgess@embecosm.com>

LGTM.  A couple nits below.

On 7/1/19 7:03 PM, Andrew Burgess wrote:

> +   This file is part of the gdb testsuite.
> +
> +   Test that a breakpoint place by line number in an assembler file

"placed", I believe.

> +   will stop at the specified line.  Previously versions of GDB have
> +   incorrectly invoked the prologue analysis logic and skipped
> +   forward.  */
> +
> +        .text
> +        .global main
> +main:
> +        nop
> +test:
> +        /* The next two instructions are required to look like an
> +	   x86-64 prologue so that GDB's prologue scanner will spot
> +           them and skip forward.  */

spaces vs tabs.

Thanks,
Pedro Alves


  reply	other threads:[~2019-07-03 22:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 12:34 [PATCH] " Andrew Burgess
2019-06-20  1:11 ` Kevin Buettner
2019-06-20 20:58   ` Andrew Burgess
2019-06-20 23:23     ` Andrew Burgess
2019-06-21  3:20       ` Kevin Buettner
2019-06-21 13:43       ` Pedro Alves
2019-06-22 11:06         ` Andrew Burgess
2019-06-22 11:23           ` Andrew Burgess
2019-06-24 19:16             ` Pedro Alves
2019-06-24 19:54               ` [PROTOTYPE] Make "info breakpoints" show breakpoint's specs (Re: [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler) Pedro Alves
2019-07-03 22:37                 ` Pedro Alves
2019-06-24 19:16           ` [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler Pedro Alves
2019-07-01 17:12             ` Andrew Burgess
2019-07-01 18:03               ` [PATCHv2 2/2] " Andrew Burgess
2019-07-03 22:13                 ` Pedro Alves [this message]
2019-07-01 18:03               ` [PATCHv2 1/2] gdb: Remove unneeded parameter from set_breakpoint_location_function Andrew Burgess
2019-07-03 22:13                 ` Pedro Alves
2019-07-01 18:03               ` [PATCHv2 0/2] Changes for explicit_line tracking, and prologue skipping Andrew Burgess
2019-07-01 18:21               ` [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler Pedro Alves
2019-07-02  8:28                 ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b474d566-32bf-98d1-de1c-ac41c03b56ac@redhat.com \
    --to=palves@redhat.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox