From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157249-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30618 invoked by alias); 3 Jul 2019 22:13:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30610 invoked by uid 89); 3 Jul 2019 22:13:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Received:6000
X-HELO: mail-wr1-f41.google.com
Received: from mail-wr1-f41.google.com (HELO mail-wr1-f41.google.com) (209.85.221.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jul 2019 22:13:52 +0000
Received: by mail-wr1-f41.google.com with SMTP id n4so4424934wrw.13        for <gdb-patches@sourceware.org>; Wed, 03 Jul 2019 15:13:52 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id m24sm3868233wmi.39.2019.07.03.15.13.49        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Wed, 03 Jul 2019 15:13:49 -0700 (PDT)
Subject: Re: [PATCHv2 2/2] gdb: Don't skip prologue for explicit line breakpoints in assembler
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
References: <cover.1562003938.git.andrew.burgess@embecosm.com> <95293b54fddd6327ba75d1d69ce7c2118c02cb70.1562003938.git.andrew.burgess@embecosm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <b474d566-32bf-98d1-de1c-ac41c03b56ac@redhat.com>
Date: Wed, 03 Jul 2019 22:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <95293b54fddd6327ba75d1d69ce7c2118c02cb70.1562003938.git.andrew.burgess@embecosm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-07/txt/msg00077.txt.bz2

LGTM.  A couple nits below.

On 7/1/19 7:03 PM, Andrew Burgess wrote:

> +   This file is part of the gdb testsuite.
> +
> +   Test that a breakpoint place by line number in an assembler file

"placed", I believe.

> +   will stop at the specified line.  Previously versions of GDB have
> +   incorrectly invoked the prologue analysis logic and skipped
> +   forward.  */
> +
> +        .text
> +        .global main
> +main:
> +        nop
> +test:
> +        /* The next two instructions are required to look like an
> +	   x86-64 prologue so that GDB's prologue scanner will spot
> +           them and skip forward.  */

spaces vs tabs.

Thanks,
Pedro Alves