From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Pedro Alves <palves@redhat.com>
Cc: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler
Date: Tue, 02 Jul 2019 08:28:00 -0000 [thread overview]
Message-ID: <20190702082755.GV23204@embecosm.com> (raw)
In-Reply-To: <1a5ad9a3-ec42-c733-fee8-fc051e6d31de@redhat.com>
* Pedro Alves <palves@redhat.com> [2019-07-01 19:21:43 +0100]:
> On 7/1/19 6:12 PM, Andrew Burgess wrote:
> >> Did you check whether we're already setting explicit_line when
> >> parsing "b -line N", i.e., when using the explicit locations syntax?
> > In current HEAD explicit_line will only get set for the clear, edit,
> > list, and 'info line' commands. Any variation of setting breakpoints
> > will never set explicit_line.
>
> OK, but I was also curious to know whether your patch already handles that
> case, or whether we need to set explicit_line somewhere else too.
> Maybe it already works if we end up in decode_digits_ordinary too
> with the explicit syntax.
Sorry I misunderstood your question.
Yes, if I use 'break -line N' then I do end up in
decode_digits_ordinary, so explicit_line will be set after my patch.
Thanks,
Andrew
>
> Thanks,
> Pedro Alves
prev parent reply other threads:[~2019-07-02 8:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 12:34 Andrew Burgess
2019-06-20 1:11 ` Kevin Buettner
2019-06-20 20:58 ` Andrew Burgess
2019-06-20 23:23 ` Andrew Burgess
2019-06-21 3:20 ` Kevin Buettner
2019-06-21 13:43 ` Pedro Alves
2019-06-22 11:06 ` Andrew Burgess
2019-06-22 11:23 ` Andrew Burgess
2019-06-24 19:16 ` Pedro Alves
2019-06-24 19:54 ` [PROTOTYPE] Make "info breakpoints" show breakpoint's specs (Re: [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler) Pedro Alves
2019-07-03 22:37 ` Pedro Alves
2019-06-24 19:16 ` [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler Pedro Alves
2019-07-01 17:12 ` Andrew Burgess
2019-07-01 18:03 ` [PATCHv2 2/2] " Andrew Burgess
2019-07-03 22:13 ` Pedro Alves
2019-07-01 18:03 ` [PATCHv2 1/2] gdb: Remove unneeded parameter from set_breakpoint_location_function Andrew Burgess
2019-07-03 22:13 ` Pedro Alves
2019-07-01 18:03 ` [PATCHv2 0/2] Changes for explicit_line tracking, and prologue skipping Andrew Burgess
2019-07-01 18:21 ` [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler Pedro Alves
2019-07-02 8:28 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702082755.GV23204@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox