From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41023 invoked by alias); 2 Jul 2019 08:28:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41006 invoked by uid 89); 2 Jul 2019 08:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 Jul 2019 08:27:58 +0000 Received: by mail-wm1-f65.google.com with SMTP id z23so2236728wma.4 for ; Tue, 02 Jul 2019 01:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mS7N6B3yk+Mw4mkQX0hgs3619Mk+S2uD8ZTuHKUg2CQ=; b=QfzB9b1HlPq3u/DSY7euU1w+k5x0lnv3cCjfbdQ0K1XGpB1kdxcO3tNwEJ+VhHYi1m SgRTpfKypP5MjD3m7zDmi15V0jZh8Bm8BRv4q88kLbR7Ex7G/0/XRugvPo9MqFw9QHQ3 1swmefT5aBTH53ohtxOU9/Wg6bxBPRsisvn1ammzf94ZmmND5wvyDUVc8zk2+prEn5FJ ZYjL/4zLZ/dIe75G8DUmvUQHmBDfGAZpNKBrk91/NuBmOycsXZvkTVzGBihHgkhwUiIi kqeRJ0QQ0+kNok5BulY7010n+XkVAN/nnoe2pdv6YrKuyWGO54GMYJIunjgsU0ui6w9m 5Rxg== Return-Path: Received: from localhost (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by smtp.gmail.com with ESMTPSA id s3sm2279751wmh.27.2019.07.02.01.27.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jul 2019 01:27:56 -0700 (PDT) Date: Tue, 02 Jul 2019 08:28:00 -0000 From: Andrew Burgess To: Pedro Alves Cc: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Don't skip prologue for explicit line breakpoints in assembler Message-ID: <20190702082755.GV23204@embecosm.com> References: <20190612123403.14348-1-andrew.burgess@embecosm.com> <20190619181147.69974f43@f29-4.lan> <20190620205759.GI23204@embecosm.com> <20190620232314.GJ23204@embecosm.com> <406d910b-8b63-1e93-d340-7e9ab841ad0b@redhat.com> <20190622110558.GK23204@embecosm.com> <20190701171213.GU23204@embecosm.com> <1a5ad9a3-ec42-c733-fee8-fc051e6d31de@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a5ad9a3-ec42-c733-fee8-fc051e6d31de@redhat.com> X-Fortune: Darth Vader sleeps with a Teddywookie. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00039.txt.bz2 * Pedro Alves [2019-07-01 19:21:43 +0100]: > On 7/1/19 6:12 PM, Andrew Burgess wrote: > >> Did you check whether we're already setting explicit_line when > >> parsing "b -line N", i.e., when using the explicit locations syntax? > > In current HEAD explicit_line will only get set for the clear, edit, > > list, and 'info line' commands. Any variation of setting breakpoints > > will never set explicit_line. > > OK, but I was also curious to know whether your patch already handles that > case, or whether we need to set explicit_line somewhere else too. > Maybe it already works if we end up in decode_digits_ordinary too > with the explicit syntax. Sorry I misunderstood your question. Yes, if I use 'break -line N' then I do end up in decode_digits_ordinary, so explicit_line will be set after my patch. Thanks, Andrew > > Thanks, > Pedro Alves