From: Tom de Vries <tdevries@suse.de>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] [gdb/testsuite] New test: gdb.base/check-errno.exp
Date: Thu, 2 May 2024 18:45:40 +0200 [thread overview]
Message-ID: <b4003da5-e750-483d-b4b1-ec290f522149@suse.de> (raw)
In-Reply-To: <20240502090237.69733376@f39-zbm-amd>
On 5/2/24 18:02, Kevin Buettner wrote:
>> FWIW, in a fedora rawhide container I get:
>> ...
>> XPASS: gdb.base/check-errno.exp: static-macros: print (int) errno
>> XPASS: gdb.base/check-errno.exp: pthreads-static-macros: print (int) errno
>> ...
>>
>> That matches your description, but I think these xpasses shouldn't be there.
>
> Based on bug 31693, which you recently filed, I agree. Those should
> be FAILs. I'll update it so that those tests fail instead.
>
Well, what I meant (and didn't clearly state) is that there's no good
reason to commit a test-case that produces an xpass. It usually means
that the xfail scope is too big.
Thanks,
- Tom
next prev parent reply other threads:[~2024-05-02 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 1:38 Kevin Buettner
2024-05-02 1:45 ` Kevin Buettner
2024-05-02 10:37 ` Tom de Vries
2024-05-02 16:02 ` Kevin Buettner
2024-05-02 16:45 ` Tom de Vries [this message]
2024-05-02 17:39 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4003da5-e750-483d-b4b1-ec290f522149@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox