From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OPZgBzzDM2ZVRQMAWB0awg (envelope-from ) for ; Thu, 02 May 2024 12:45:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=PE73neyb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1YyE5/KP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YNOulVCF; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=oq/FEW81; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 18E9B1E0C1; Thu, 2 May 2024 12:45:48 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFCA61E092 for ; Thu, 2 May 2024 12:45:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 759D7384AB59 for ; Thu, 2 May 2024 16:45:45 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 29B8E3858D20 for ; Thu, 2 May 2024 16:45:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29B8E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29B8E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714668322; cv=none; b=k53TKT06QyIBxfMDmykaekh4oPwDVPaffaxDCai/ClvKkiYSmnQ/a5/CRN7RYKx3p5+YD8VYqNJ0jAFXaPllTRcbqERKTIFFMYhyJAqGWmZVhypJmEV08EHjmWIun4ePJyTv3rxlvnSqTZ0760rFHIUMevBywmKs/E9IiQiZ258= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714668322; c=relaxed/simple; bh=9GdAPn5IOzxQiV1MAWTLfZ90bilhVdqY5F10radsV54=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=nMJy9bZr+1JLOiSt60+kI6xasjr2PQjcBFMk2cUKOikhsdx+yWXcZwrJppX7GcbGywitsvyAuoErSIgbSbksBNHhu4FvVhqPIo9aWPe1sDuy66t0AM4jZLKw7epvdVi/zOUhPKSkioenTvWkDD7CEnZLaY2/diapJ0f3GvuRGYc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 93D9821A2B; Thu, 2 May 2024 16:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714668318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBctu/940J9LKpbgrfhbfoT4OiXMRlbZ43fcbHIxT20=; b=PE73neybhm3rB6JS/gmJM/RYgy+8enVyD3vgCPUB4o3tGh6FxAWYli79GFT8hD+oi7mKkk WIvxp2so4ZmnPwmIdaypfsE3q6Nb6dDxH0Fu5z1vISA7Lo4PJWD4xBkpYgI80XJhmnxxR9 H2GT481pDYQeHIIIWCZyjTBJmlFt2V4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714668318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBctu/940J9LKpbgrfhbfoT4OiXMRlbZ43fcbHIxT20=; b=1YyE5/KP0d1IhF4HADSXSll9Ds9fBJZsAAfKM/PWC1SGODIvQHwCvgJebSFuKZ0uPK7oZG AUEZsEtZ1c5XwqAQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714668317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBctu/940J9LKpbgrfhbfoT4OiXMRlbZ43fcbHIxT20=; b=YNOulVCFta9cwS14PH4Ba1Pe2ndqOxqJFn2mh88JTvrrf1j1EIvEs2tN82ogceIHi3vk8F +7JIfKHCY95aHGA0Qo2BEZb8G9XtdYybHYNLuE5pbHS7J76sBpfm5lHH6R+K94CjY/gGyo TcGCiatDkBCwpFrwQMjyIrG0uyYYDAE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714668317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBctu/940J9LKpbgrfhbfoT4OiXMRlbZ43fcbHIxT20=; b=oq/FEW815FPwxDQb6gH3GcoNKsz/2s/5Z0qHGPB6FwG91MB91eHUX8DAGqsSO0ir2EozuX j5JliPzhHLlKwlAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7C1FB1386E; Thu, 2 May 2024 16:45:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rePXHB3DM2ZQEgAAD6G6ig (envelope-from ); Thu, 02 May 2024 16:45:17 +0000 Message-ID: Date: Thu, 2 May 2024 18:45:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] [gdb/testsuite] New test: gdb.base/check-errno.exp To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20240502013934.389445-1-kevinb@redhat.com> <6f42cbea-053c-4c49-b82b-428bf55ec101@suse.de> <20240502090237.69733376@f39-zbm-amd> Content-Language: en-US From: Tom de Vries In-Reply-To: <20240502090237.69733376@f39-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.29 X-Spam-Level: X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.984]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 5/2/24 18:02, Kevin Buettner wrote: >> FWIW, in a fedora rawhide container I get: >> ... >> XPASS: gdb.base/check-errno.exp: static-macros: print (int) errno >> XPASS: gdb.base/check-errno.exp: pthreads-static-macros: print (int) errno >> ... >> >> That matches your description, but I think these xpasses shouldn't be there. > > Based on bug 31693, which you recently filed, I agree. Those should > be FAILs. I'll update it so that those tests fail instead. > Well, what I meant (and didn't clearly state) is that there's no good reason to commit a test-case that produces an xpass. It usually means that the xfail scope is too big. Thanks, - Tom