Re: [PATCH v3] [gdb/testsuite] New test: gdb.base/check-errno.exp

[Kevin Buettner <kevinb@redhat.com>]

On Thu, 2 May 2024 18:45:40 +0200
Tom de Vries <tdevries@suse.de> wrote:

> On 5/2/24 18:02, Kevin Buettner wrote:
> >> FWIW, in a fedora rawhide container I get:
> >> ...
> >> XPASS: gdb.base/check-errno.exp: static-macros: print (int) errno
> >> XPASS: gdb.base/check-errno.exp: pthreads-static-macros: print (int) errno
> >> ...
> >>
> >> That matches your description, but I think these xpasses shouldn't be there.  
> > 
> > Based on bug 31693, which you recently filed, I agree.  Those should
> > be FAILs.  I'll update it so that those tests fail instead.
> >   
> 
> Well, what I meant (and didn't clearly state) is that there's no good 
> reason to commit a test-case that produces an xpass.  It usually means 
> that the xfail scope is too big.

Yeah, that makes sense.

But in this case, as you've demonstrated, there's a bug in GDB, so it
doesn't make sense to set up an xfail for them.

I'm looking at your "Fix cast handling for indirection" patch now and
will wait for it to land before posting a new version of my
check-errno patch.

Kevin