From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C+ciHv/PM2ZBVgMAWB0awg (envelope-from ) for ; Thu, 02 May 2024 13:40:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZQwLjYd3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A84B1E0C1; Thu, 2 May 2024 13:40:15 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 228AE1E092 for ; Thu, 2 May 2024 13:40:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95913384AB44 for ; Thu, 2 May 2024 17:40:12 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1042E3858D20 for ; Thu, 2 May 2024 17:39:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1042E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1042E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714671592; cv=none; b=Dh2yy8RZzkgc5dxybaiOTXm/rFs/+L3Y2Cc54f8F7mo/RB0E2ZQcpdDc6HtU7E1zdJubgm3zAzXR7ATbBhLgh3ey78EVrW9EQOyln9q9FLWgP6KnCmwwFP89giE1AJ6uL2+1WvsfpXQRNExGBWstIoVk8XLi/HPlLJGn8zdc8FE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714671592; c=relaxed/simple; bh=0o6/M0Jbz8mG9DUOEAUVNq7aI11FnkhwuX6B2TXHf8E=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=m0ItTt0GOPa/JOHrK/ryy7V6MBgQEDv+5EvQwPCWGAC6PWG6Dvp/HMOYQHbbs0hkeHqh491SeSwIpt8+1cW++Lx2c38ZySxwjRRjB5DkxupBVA4kqNx6vKrUJTRIw/3H9wlNGPsE/08GaMIGpeU1HitNM5rkcQYyeSXTt55sMhs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714671590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Scqj6YyTdISA9BsxdnA88Ze2eFkM02/ovfjzF33KXug=; b=ZQwLjYd3jPJUFYQxBpX1UsCNVhuvC9JJzXhfMYzVIoVaJ6vwxMxfyfch+61yXW4M26YNfM BHjNuAfQhzBCLjVYyuwC8jHahAjSt1yZDtXQwUlVKTThwJamp/M3WW/djrmRphKQIw5Lqt gD7EH3//saCRWCPuui6lx1SAU6rsOJ0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-YFpENyPtOV2yALtW6ghqjQ-1; Thu, 02 May 2024 13:39:47 -0400 X-MC-Unique: YFpENyPtOV2yALtW6ghqjQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75BC580021A; Thu, 2 May 2024 17:39:47 +0000 (UTC) Received: from f39-zbm-amd (unknown [10.22.16.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3052F2166B31; Thu, 2 May 2024 17:39:47 +0000 (UTC) Date: Thu, 2 May 2024 10:39:44 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] [gdb/testsuite] New test: gdb.base/check-errno.exp Message-ID: <20240502103944.1dd73a71@f39-zbm-amd> In-Reply-To: References: <20240502013934.389445-1-kevinb@redhat.com> <6f42cbea-053c-4c49-b82b-428bf55ec101@suse.de> <20240502090237.69733376@f39-zbm-amd> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Thu, 2 May 2024 18:45:40 +0200 Tom de Vries wrote: > On 5/2/24 18:02, Kevin Buettner wrote: > >> FWIW, in a fedora rawhide container I get: > >> ... > >> XPASS: gdb.base/check-errno.exp: static-macros: print (int) errno > >> XPASS: gdb.base/check-errno.exp: pthreads-static-macros: print (int) errno > >> ... > >> > >> That matches your description, but I think these xpasses shouldn't be there. > > > > Based on bug 31693, which you recently filed, I agree. Those should > > be FAILs. I'll update it so that those tests fail instead. > > > > Well, what I meant (and didn't clearly state) is that there's no good > reason to commit a test-case that produces an xpass. It usually means > that the xfail scope is too big. Yeah, that makes sense. But in this case, as you've demonstrated, there's a bug in GDB, so it doesn't make sense to set up an xfail for them. I'm looking at your "Fix cast handling for indirection" patch now and will wait for it to land before posting a new version of my check-errno patch. Kevin