Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Remove best_symbol and better_symbol
Date: Sun, 8 Feb 2026 00:16:49 +0100	[thread overview]
Message-ID: <b3efcb9a-b039-43d8-ad16-9bfcf8643174@suse.de> (raw)
In-Reply-To: <87v7g8wrc6.fsf@tromey.com>

On 2/7/26 3:39 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
> Tom> This patch removes best_symbol and better_symbol.
> [...]
> 
> I'm going to check this in now.


I'm seeing regressions due to this commit.  For instance, in test-case 
gdb.base/condbreak-call-false.exp:
...
(gdb) PASS: gdb.base/condbreak-call-false.exp: break bar
c^M
Continuing.^M
Error in testing condition for breakpoint 2:^M
Invalid data type for function to be called.^M
^M
Breakpoint 2, foo () at 
/data/vries/gdb/src/gdb/testsuite/gdb.base/condbreak-call-false.c:25^M
25        return 23;^M
(gdb) FAIL: gdb.base/condbreak-call-false.exp: c
...

Thanks,
- Tom

  reply	other threads:[~2026-02-07 23:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13 19:14 Tom Tromey
2026-02-07 14:39 ` Tom Tromey
2026-02-07 23:16   ` Tom de Vries [this message]
2026-02-08  1:06     ` Tom Tromey
2026-02-08 10:46       ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3efcb9a-b039-43d8-ad16-9bfcf8643174@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox