From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Remove best_symbol and better_symbol
Date: Sun, 8 Feb 2026 11:46:21 +0100 [thread overview]
Message-ID: <6b253a69-e29f-40c1-b7c9-793e214bd483@suse.de> (raw)
In-Reply-To: <87cy2gvybf.fsf@tromey.com>
On 2/8/26 2:06 AM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> On 2/7/26 3:39 PM, Tom Tromey wrote:
>>>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
> Tom> This patch removes best_symbol and better_symbol.
>>> [...]
>>> I'm going to check this in now.
>
>
> Tom> I'm seeing regressions due to this commit. For instance, in test-case
> Tom> gdb.base/condbreak-call-false.exp:
>
> Sorry about that.
> I will debug it ASAP but if you want you can back it out.
I've:
- filed a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33884 ),
- did some investigation which I posted in the PR, and
- reverted the commit (
https://sourceware.org/pipermail/gdb-patches/2026-February/224833.html ).
I've reverted for my convenience, I don't know if others are affected as
well.
Thanks,
- Tom
prev parent reply other threads:[~2026-02-08 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-13 19:14 Tom Tromey
2026-02-07 14:39 ` Tom Tromey
2026-02-07 23:16 ` Tom de Vries
2026-02-08 1:06 ` Tom Tromey
2026-02-08 10:46 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b253a69-e29f-40c1-b7c9-793e214bd483@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox