From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UbAtMptpiGl9JjAAWB0awg (envelope-from ) for ; Sun, 08 Feb 2026 05:46:51 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AROWiJrp; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4zNczUd5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=po1e5RDQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kk0EWypt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B0FF91E089; Sun, 08 Feb 2026 05:46:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B85C61E089 for ; Sun, 08 Feb 2026 05:46:50 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2C7DF48FDB06 for ; Sun, 8 Feb 2026 10:46:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C7DF48FDB06 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AROWiJrp; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4zNczUd5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=po1e5RDQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kk0EWypt Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D868C4B920C9 for ; Sun, 8 Feb 2026 10:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D868C4B920C9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D868C4B920C9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770547583; cv=none; b=tBrD7ODRhm5CEdRWuAIk1AKCcoyFkuIRkCk+1aDAHWKkdK85rY379zt+aRByrlpkQiPYbVRQa95R4hdr2QEkoC7SSrgG8qV93jHGwGPEkRdcbindeUroHp9OETxEtMLEZPSsxydVQCLxx9xU0hEx1i0gJHi/zat76eGj07t4ywo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770547583; c=relaxed/simple; bh=O+2Y5TSoZKjEljZB8QsW+lM2mhhOHyZFuV2Lo0tlts8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=PhCTxpQ+cjRW278Ua1wF/U/eMilpOPvOvYB6JSm/wbmGnAt/wCroVQwxBtLhK5SBI10gL61OKODps+hCc8U/5qsWML7Z6gxueEPLq/Mz/J3/+IypjEb8SaGb47FKq4Xxcai0ogimU1Us445+Oofgt0xArvse40Dzg/7DavqedPI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D868C4B920C9 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1FB23E6C6; Sun, 8 Feb 2026 10:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770547582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S5uT6XjoFLi8xZksFBG0i4bH4l4FpQbb+KJ19qCG+Gg=; b=AROWiJrp/dMJsSWIFqUt1XuQ59ba+KhT08x0aq7QpQyBKFYbA3jtgx8DMw2Nosgi91Rgh0 2I6S4ybbG8Gcgc1NzrYCNvIK2gSdNPdcS/CdGK/xXgWSLjRFejuvbMST2r3+FUSjFJvcHl 3U4asDftAYXdhwJdUBJvEQi6OwNQURs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770547582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S5uT6XjoFLi8xZksFBG0i4bH4l4FpQbb+KJ19qCG+Gg=; b=4zNczUd5Nbiyg6eAgk/ilujBSZzPRnKoaPD/6gu+tlGP9+E+ALMaLn7eBA21ZU7s3NZwtN wfw2QtdaSNYorwAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770547581; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S5uT6XjoFLi8xZksFBG0i4bH4l4FpQbb+KJ19qCG+Gg=; b=po1e5RDQxRvEicDnZ4qhAGhijJKznzJrA+mhlHskbyjRvfb9S9zTWjgOi1fuObH6PTRmOE iopWl1HN4G6y7t6uPB/NzZcuRYgD7XdEW5DsTKJgTuuT0YSBliARSsMa7yISeb2U0cP/5g rKLJj18T6wX1FmWX3SqeOuYEGeOxLWE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770547581; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S5uT6XjoFLi8xZksFBG0i4bH4l4FpQbb+KJ19qCG+Gg=; b=kk0EWyptIc/v2ex4c4kFjRggQz+XvppGqtr9RHjlTwfKh8708weChjsQVwJubIZtFbj2ep 9aKKJcQR018OvZAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B31833EA63; Sun, 8 Feb 2026 10:46:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id htprKX1piGnMbQAAD6G6ig (envelope-from ); Sun, 08 Feb 2026 10:46:21 +0000 Message-ID: <6b253a69-e29f-40c1-b7c9-793e214bd483@suse.de> Date: Sun, 8 Feb 2026 11:46:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Remove best_symbol and better_symbol To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20251213191428.1928246-1-tom@tromey.com> <87v7g8wrc6.fsf@tromey.com> <87cy2gvybf.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87cy2gvybf.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/8/26 2:06 AM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> On 2/7/26 3:39 PM, Tom Tromey wrote: >>>>>>>> "Tom" == Tom Tromey writes: > Tom> This patch removes best_symbol and better_symbol. >>> [...] >>> I'm going to check this in now. > > > Tom> I'm seeing regressions due to this commit. For instance, in test-case > Tom> gdb.base/condbreak-call-false.exp: > > Sorry about that. > I will debug it ASAP but if you want you can back it out. I've: - filed a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33884 ), - did some investigation which I posted in the PR, and - reverted the commit ( https://sourceware.org/pipermail/gdb-patches/2026-February/224833.html ). I've reverted for my convenience, I don't know if others are affected as well. Thanks, - Tom