From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yNKhDwLIh2mLJC8AWB0awg (envelope-from ) for ; Sat, 07 Feb 2026 18:17:22 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=P8eVQud8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rpYSCBFy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=P8eVQud8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rpYSCBFy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1AB661E0BA; Sat, 07 Feb 2026 18:17:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59ADB1E08D for ; Sat, 07 Feb 2026 18:17:20 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 48C1D48F1972 for ; Sat, 7 Feb 2026 23:17:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48C1D48F1972 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=P8eVQud8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rpYSCBFy; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=P8eVQud8; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rpYSCBFy Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 6246648F36B5 for ; Sat, 7 Feb 2026 23:16:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6246648F36B5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6246648F36B5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770506211; cv=none; b=g6hEprZbcf43GTjG6BCz0btk4DR00HnxydlFYyjKzVvemFEiuo933wxGjOYdhbhMOmEfpDlUaPBF8fADndkHBtMoouQm/tCNc2nq8OsK33qG6qt57EmCPOqYIuuYrUHnJzThLXnsJi53Cgfc/GxWukV64jiDf+peTgMU3S99snk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770506211; c=relaxed/simple; bh=amGJA72gjGgXaOYL5IrpeDLxIjBSWITtYKaaHMF9YdY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=CeXhNrf8dDckk/mCU3LK6edhyhnENAbcV/NkKbayTeAupBJUVvM5kGW+WYt5uShURcWS1at77G9LOROnARXLQfkctsnOftnX1ggXosk144XLhKoycanGHtJvJkLmMjyGSwxsaO9BGBJtn+fMqFeUy4YP6jAXMG3BNvijpgpYXmo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6246648F36B5 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 296315BCC4; Sat, 7 Feb 2026 23:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770506210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wm3Jk1v1wnv+Y15hK2EgU9qNqb39IzSdVVhCiCeR1Pg=; b=P8eVQud8lUFTb5EkqYpC9ithxo34Vbq/dnX5GJcJGT1RFihgeDFjBTMf6R6WnR+h4uLsPd U+ZHfZpVO3bunspppJFld0oT+vr6WSBxxF4aSk/DgZgAf2/5e82ylLSPPrjNxE9tonLGSY 7XfneidgGu3GQg0uoZcPO75gcZJXf2s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770506210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wm3Jk1v1wnv+Y15hK2EgU9qNqb39IzSdVVhCiCeR1Pg=; b=rpYSCBFy1nxLr70MB1itjJpHpvDMYctHbzIGg2C85ZiYVF3NmMzLp4AAtE4A4spLqJ8ZD0 Fc5PBRbTMb2YDpCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=P8eVQud8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rpYSCBFy DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770506210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wm3Jk1v1wnv+Y15hK2EgU9qNqb39IzSdVVhCiCeR1Pg=; b=P8eVQud8lUFTb5EkqYpC9ithxo34Vbq/dnX5GJcJGT1RFihgeDFjBTMf6R6WnR+h4uLsPd U+ZHfZpVO3bunspppJFld0oT+vr6WSBxxF4aSk/DgZgAf2/5e82ylLSPPrjNxE9tonLGSY 7XfneidgGu3GQg0uoZcPO75gcZJXf2s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770506210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wm3Jk1v1wnv+Y15hK2EgU9qNqb39IzSdVVhCiCeR1Pg=; b=rpYSCBFy1nxLr70MB1itjJpHpvDMYctHbzIGg2C85ZiYVF3NmMzLp4AAtE4A4spLqJ8ZD0 Fc5PBRbTMb2YDpCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0D3893EA63; Sat, 7 Feb 2026 23:16:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Y+6jAeLHh2mnJgAAD6G6ig (envelope-from ); Sat, 07 Feb 2026 23:16:50 +0000 Message-ID: Date: Sun, 8 Feb 2026 00:16:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Remove best_symbol and better_symbol To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20251213191428.1928246-1-tom@tromey.com> <87v7g8wrc6.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87v7g8wrc6.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 296315BCC4 X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/7/26 3:39 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> This patch removes best_symbol and better_symbol. > [...] > > I'm going to check this in now. I'm seeing regressions due to this commit. For instance, in test-case gdb.base/condbreak-call-false.exp: ... (gdb) PASS: gdb.base/condbreak-call-false.exp: break bar c^M Continuing.^M Error in testing condition for breakpoint 2:^M Invalid data type for function to be called.^M ^M Breakpoint 2, foo () at /data/vries/gdb/src/gdb/testsuite/gdb.base/condbreak-call-false.c:25^M 25 return 23;^M (gdb) FAIL: gdb.base/condbreak-call-false.exp: c ... Thanks, - Tom