From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb: make thread_suspend_state::stop_pc optional
Date: Tue, 7 Sep 2021 10:10:07 -0400 [thread overview]
Message-ID: <b3e86f78-c81d-e0a7-84d8-5af084286c0d@polymtl.ca> (raw)
In-Reply-To: <20210907132103.GQ2581@embecosm.com>
On 2021-09-07 9:21 a.m., Andrew Burgess wrote:
> * Simon Marchi <simon.marchi@polymtl.ca> [2021-09-01 10:23:32 -0400]:
>
>>
>>
>> On 2021-08-30 4:03 p.m., Andrew Burgess wrote:
>>> Currently the stop_pc field of thread_suspect_state is a CORE_ADDR and
>>> when we want to indicate that there is no stop_pc available we set
>>> this field back to a special value.
>>>
>>> There are actually two special values used, in post_create_inferior
>>> the stop_pc is set to 0. This is a little unfortunate, there are
>>> plenty of embedded targets where 0 is a valid pc address. The more
>>> common special value for stop_pc was set in
>>> thread_info::set_executing, where the value (~(CORE_ADDR) 0) was used.
>>>
>>> This commit changes things so that the stop_pc is instead a
>>> gdb::optional. We can now explicitly reset the field to an
>>> uninitialised state, we also have (when compiling with _GLIBCXX_DEBUG
>>> defined) asserts that we don't read the stop_pc when its in an
>>> uninitialised state (see gdbsupport/gdb_optional.h).
>>
>> Thanks, I think it's a good idea.
>>
>>> One situation where a thread will not have a stop_pc value is when the
>>> thread is stopped as a consequence of GDB being in all stop mode, and
>>> some other thread stopped at an interesting event. When GDB brings
>>> all the other threads to a stop those other threads will not have a
>>> stop_pc set (thus avoiding an unnecessary read of $pc).
>>>
>>> Previously, when GDB passed through handle_one (in infrun.c) the
>>> threads executing flag was set to false and the stop_pc field was left
>>> unchanged, i.e. it would (previous) have been left as ~0.
>>>
>>> Now, handle_one leaves the stop_pc with no value.
>>>
>>> This caused a problem when we later try to set these threads running
>>> again, in proceed() we compare the current pc with the cached
>>> stop_pc. If the thread was stopped in via handle_one then the stop_pc
>>> would have been left as ~0, and the compare (in proceed)
>>> would (likely) fail. Now however, this compare tries to read the
>>> stop_pc when it has no value, this would trigger an assert.
>>>
>>> To resolve this I've added thread_info::stop_pc_p() which returns true
>>> if the thread has a cached stop_pc. We should only ever call
>>> thread_info::stop_pc() if we know that there is a cached stop_pc.
>>
>> We could also make stop_pc return gdb::optional<CORE_ADDR>. I think it
>> would be slightly better, since anybody calling stop_pc would see that
>> it returns an optional and be forced to consider that. Otherwise, one
>> could call stop_pc and not know that stop_pc_p exists. But otherwise
>> it's the same.
>
> I did consider that initially, but most of the places where
> thread_info::stop_pc is called the value is being immediately passed
> through to some other function, here's an example pulled randomly from
> infrun.c:
>
> ecs->event_thread->control.stop_bpstat
> = bpstat_stop_status (get_current_regcache ()->aspace (),
> ecs->event_thread->stop_pc (),
> ecs->event_thread, &ecs->ws);
>
> if we are returned a gdb::optional<> then we might change the code to
> do this:
>
> ecs->event_thread->control.stop_bpstat
> = bpstat_stop_status (get_current_regcache ()->aspace (),
> *ecs->event_thread->stop_pc (),
> ecs->event_thread, &ecs->ws);
>
> Or maybe, like this:
>
> auto stop_pc = ecs->event_thread->stop_pc ();
> gdb_assert (stop_pc.has_value ());
> ecs->event_thread->control.stop_bpstat
> = bpstat_stop_status (get_current_regcache ()->aspace (),
> *stop_pc,
> ecs->event_thread, &ecs->ws);
>
> In the first case, it doesn't feel like we've gained much over my
> patch, where thead_info::stop_pc() accesses the value for us.
> Further, once we've normalised the pattern of accessing the stop_pc as
> `*ecs->event_thread->stop_pc ()`, I worry people still wouldn't
> actually consider whether the stop_pc value was valid or not, they'd
> just duplicate the existing code.
>
> The second case seems excessively verbose, so much so, that you might
> even be tempted to write a wrapper, say thread_info::stop_pc_value(),
> which kind lands us back on my original patch...
>
> Initially, I'd relied on the asserts within gdb::optional to ensure
> that we didn't access the stop_pc when it had no value, but these
> asserts are only present when compiling with _GLIBCXX_DEBUG defined -
> I do this, but it's certainly not going to be standard in a release
> build of GDB. So, I wonder if this would be a good change:
>
> /* Return this thread's stop PC. This should only be called when it is
> known that stop_pc has a value. If this function is being used in a
> situation where a thread may not have had a stop_pc assigned, then
> stop_pc_p() can be used to check if the stop_pc is defined. */
>
> CORE_ADDR stop_pc () const
> {
> gdb_assert (m_suspend.stop_pc.has_value ());
> return *m_suspend.stop_pc;
> }
That one looks good to me, stating preconditions in the documentation
and enforcing them using assertions. That's similar to how I designed
other things, like dynamic_prop.
Simon
next prev parent reply other threads:[~2021-09-07 14:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 20:03 [PATCH 0/3] Changes to thread state tracking Andrew Burgess
2021-08-30 20:03 ` [PATCH 1/3] gdb: make thread_info::executing private Andrew Burgess
2021-09-01 13:53 ` Simon Marchi via Gdb-patches
2021-09-07 11:46 ` Andrew Burgess
2021-08-30 20:03 ` [PATCH 2/3] gdb: make thread_suspend_state::stop_pc optional Andrew Burgess
2021-09-01 14:23 ` Simon Marchi via Gdb-patches
2021-09-07 13:21 ` Andrew Burgess
2021-09-07 14:10 ` Simon Marchi via Gdb-patches [this message]
2021-09-08 9:50 ` Andrew Burgess
2021-08-30 20:03 ` [PATCH 3/3] gdb: make thread_info executing and resumed state more consistent Andrew Burgess
2021-09-01 15:09 ` Simon Marchi via Gdb-patches
2021-09-22 11:21 ` Andrew Burgess
2021-09-23 17:14 ` Simon Marchi via Gdb-patches
2021-09-29 8:09 ` Andrew Burgess
2021-10-08 19:33 ` Simon Marchi via Gdb-patches
2022-01-13 18:34 ` [PATCHv3] " Andrew Burgess via Gdb-patches
2022-01-14 17:10 ` Simon Marchi via Gdb-patches
2022-02-24 15:52 ` Andrew Burgess via Gdb-patches
2022-03-03 19:42 ` Simon Marchi via Gdb-patches
2022-03-07 7:39 ` Aktemur, Tankut Baris via Gdb-patches
2022-03-30 9:19 ` Andrew Burgess via Gdb-patches
2022-04-21 16:45 ` [PATCHv4 0/2] Make " Andrew Burgess via Gdb-patches
2022-04-21 16:45 ` [PATCHv4 1/2] gdb: add some additional thread status debug output Andrew Burgess via Gdb-patches
2022-04-21 20:35 ` Lancelot SIX via Gdb-patches
2022-04-22 17:50 ` Andrew Burgess via Gdb-patches
2022-05-03 14:04 ` Andrew Burgess via Gdb-patches
2022-04-21 16:45 ` [PATCHv4 2/2] gdb: make thread_info executing and resumed state more consistent Andrew Burgess via Gdb-patches
2022-04-26 13:28 ` Nidal Faour via Gdb-patches
2022-08-08 11:04 ` [PATCHv4 0/2] Make " Craig Blackmore
2022-08-08 12:01 ` Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e86f78-c81d-e0a7-84d8-5af084286c0d@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=andrew.burgess@embecosm.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox