From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] gdb: make thread_info::executing private
Date: Wed, 1 Sep 2021 09:53:31 -0400 [thread overview]
Message-ID: <1b625bf0-9a43-801c-4a5a-a880de986106@polymtl.ca> (raw)
In-Reply-To: <0fc4a9e754ad23dad99afdbeafa1388791135408.1630353626.git.andrew.burgess@embecosm.com>
> @@ -841,24 +851,11 @@ set_running (process_stratum_target *targ, ptid_t ptid, bool running)
> gdb::observers::target_resumed.notify (ptid);
> }
>
> -
> -/* Helper for set_executing. Set's the thread's 'executing' field
> - from EXECUTING, and if EXECUTING is true also clears the thread's
> - stop_pc. */
That comment should probably be moved to the set_executing
declaration, in the thread_info class. The part about clearing stop_pc
is relevant to have there, I think.
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2021-09-01 13:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 20:03 [PATCH 0/3] Changes to thread state tracking Andrew Burgess
2021-08-30 20:03 ` [PATCH 1/3] gdb: make thread_info::executing private Andrew Burgess
2021-09-01 13:53 ` Simon Marchi via Gdb-patches [this message]
2021-09-07 11:46 ` Andrew Burgess
2021-08-30 20:03 ` [PATCH 2/3] gdb: make thread_suspend_state::stop_pc optional Andrew Burgess
2021-09-01 14:23 ` Simon Marchi via Gdb-patches
2021-09-07 13:21 ` Andrew Burgess
2021-09-07 14:10 ` Simon Marchi via Gdb-patches
2021-09-08 9:50 ` Andrew Burgess
2021-08-30 20:03 ` [PATCH 3/3] gdb: make thread_info executing and resumed state more consistent Andrew Burgess
2021-09-01 15:09 ` Simon Marchi via Gdb-patches
2021-09-22 11:21 ` Andrew Burgess
2021-09-23 17:14 ` Simon Marchi via Gdb-patches
2021-09-29 8:09 ` Andrew Burgess
2021-10-08 19:33 ` Simon Marchi via Gdb-patches
2022-01-13 18:34 ` [PATCHv3] " Andrew Burgess via Gdb-patches
2022-01-14 17:10 ` Simon Marchi via Gdb-patches
2022-02-24 15:52 ` Andrew Burgess via Gdb-patches
2022-03-03 19:42 ` Simon Marchi via Gdb-patches
2022-03-07 7:39 ` Aktemur, Tankut Baris via Gdb-patches
2022-03-30 9:19 ` Andrew Burgess via Gdb-patches
2022-04-21 16:45 ` [PATCHv4 0/2] Make " Andrew Burgess via Gdb-patches
2022-04-21 16:45 ` [PATCHv4 1/2] gdb: add some additional thread status debug output Andrew Burgess via Gdb-patches
2022-04-21 20:35 ` Lancelot SIX via Gdb-patches
2022-04-22 17:50 ` Andrew Burgess via Gdb-patches
2022-05-03 14:04 ` Andrew Burgess via Gdb-patches
2022-04-21 16:45 ` [PATCHv4 2/2] gdb: make thread_info executing and resumed state more consistent Andrew Burgess via Gdb-patches
2022-04-26 13:28 ` Nidal Faour via Gdb-patches
2022-08-08 11:04 ` [PATCHv4 0/2] Make " Craig Blackmore
2022-08-08 12:01 ` Andrew Burgess via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b625bf0-9a43-801c-4a5a-a880de986106@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=andrew.burgess@embecosm.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox