Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
To: Craig Blackmore <craig.blackmore@embecosm.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCHv4 0/2] Make thread_info executing and resumed state more consistent
Date: Mon, 08 Aug 2022 13:01:46 +0100	[thread overview]
Message-ID: <87fsi70wr9.fsf@redhat.com> (raw)
In-Reply-To: <3480a85f-09e5-8c24-826c-a3fd563a013c@embecosm.com>

Craig Blackmore <craig.blackmore@embecosm.com> writes:

> On 21/04/2022 17:45, Andrew Burgess via Gdb-patches wrote:
>> And I'm back on this patch again!
>>
>> I've rebased this onto current master and done some testing.  I
>> haven't found any regressions, but as I've said before, this change
>> touches every target, and my testing on anything other than GNU/Linux
>> (x86-64) is pretty thin, so I'm fully expecting this to introduce some
>> issues - these issues _should_ be limited to assertion failures when
>> threads are not in the expected states, I would hope there's no
>> crashes being introduced.
>>
>> There's been no significant changes since v3.  I have split out a
>> little bit of the debug printing code (the new #1 patch), but the
>> second patch is pretty much the same as v3.
>>
>> V3 was given a cautious OK, but I wanted to advertise this patch again
>> in case anyone wants to object before I merge this.
>
> Hi Andrew,
>
> Do you still intend to merge the second patch in this series?

I do intend to return to this work, but I have another patch that I need
to get finished first before I'll have any free time to look at this.

When I do go back to this work I'm tempted to start fresh.  I was always
a little unsure about all the changes to the new thread creation code
(setting the resumed/executing flags in new threads), and I'm hoping
that if I start fresh then I might be able to come up with something
that feels a little cleaner.

That said, I'd certainly be supportive if anyone wanted to take this
patch on and move it forward.

Thanks,
Andrew


      reply	other threads:[~2022-08-08 12:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 20:03 [PATCH 0/3] Changes to thread state tracking Andrew Burgess
2021-08-30 20:03 ` [PATCH 1/3] gdb: make thread_info::executing private Andrew Burgess
2021-09-01 13:53   ` Simon Marchi via Gdb-patches
2021-09-07 11:46     ` Andrew Burgess
2021-08-30 20:03 ` [PATCH 2/3] gdb: make thread_suspend_state::stop_pc optional Andrew Burgess
2021-09-01 14:23   ` Simon Marchi via Gdb-patches
2021-09-07 13:21     ` Andrew Burgess
2021-09-07 14:10       ` Simon Marchi via Gdb-patches
2021-09-08  9:50         ` Andrew Burgess
2021-08-30 20:03 ` [PATCH 3/3] gdb: make thread_info executing and resumed state more consistent Andrew Burgess
2021-09-01 15:09   ` Simon Marchi via Gdb-patches
2021-09-22 11:21     ` Andrew Burgess
2021-09-23 17:14       ` Simon Marchi via Gdb-patches
2021-09-29  8:09         ` Andrew Burgess
2021-10-08 19:33           ` Simon Marchi via Gdb-patches
2022-01-13 18:34   ` [PATCHv3] " Andrew Burgess via Gdb-patches
2022-01-14 17:10     ` Simon Marchi via Gdb-patches
2022-02-24 15:52       ` Andrew Burgess via Gdb-patches
2022-03-03 19:42         ` Simon Marchi via Gdb-patches
2022-03-07  7:39           ` Aktemur, Tankut Baris via Gdb-patches
2022-03-30  9:19         ` Andrew Burgess via Gdb-patches
2022-04-21 16:45     ` [PATCHv4 0/2] Make " Andrew Burgess via Gdb-patches
2022-04-21 16:45       ` [PATCHv4 1/2] gdb: add some additional thread status debug output Andrew Burgess via Gdb-patches
2022-04-21 20:35         ` Lancelot SIX via Gdb-patches
2022-04-22 17:50           ` Andrew Burgess via Gdb-patches
2022-05-03 14:04             ` Andrew Burgess via Gdb-patches
2022-04-21 16:45       ` [PATCHv4 2/2] gdb: make thread_info executing and resumed state more consistent Andrew Burgess via Gdb-patches
2022-04-26 13:28       ` Nidal Faour via Gdb-patches
2022-08-08 11:04       ` [PATCHv4 0/2] Make " Craig Blackmore
2022-08-08 12:01         ` Andrew Burgess via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsi70wr9.fsf@redhat.com \
    --to=gdb-patches@sourceware.org \
    --cc=aburgess@redhat.com \
    --cc=craig.blackmore@embecosm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox