Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
	       Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] [testsuite patch] Fix gdb.btrace/tailcall-only.exp errors on x86_64-m32
Date: Wed, 20 Jul 2016 14:36:00 -0000	[thread overview]
Message-ID: <b370d5c2-6dab-bcd4-be69-0d020a6019ec@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B23332F7026@IRSMSX104.ger.corp.intel.com>

On 07/20/2016 03:26 PM, Metzger, Markus T wrote:
>> From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]
>> On Wed, 20 Jul 2016 16:02:20 +0200, Pedro Alves wrote:

>>> But, multilib-style testing with --target_board=unix\{-m64,-m32\} etc.
>>> should work _too_, IMO.
>>
>> Checked in:
>> 	7674d381b47f9f2411c0ca1da0c152940dc0d7bd
> 
> Would this also work for x32?

Not sure this particular commit, but AFAIK, there's no target
triplet for x32, even.  Presumably people run x32 testing
with --target_board=unix/-mx32.  I'm on Fedora so can't test it, myself.

So using is_lp64_target / is_amd64_regs_target /  is_x86_like_target etc.
checks is really the only way to make a testcase detect it's targeting
x32, and adjust itself, skip, etc..  

Thanks,
Pedro Alves


  parent reply	other threads:[~2016-07-20 14:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 15:53 Jan Kratochvil
2016-04-11  6:44 ` Metzger, Markus T
2016-04-11 19:55   ` Jan Kratochvil
2016-07-20 14:02   ` Pedro Alves
2016-07-20 14:22     ` [commit] " Jan Kratochvil
2016-07-20 14:26       ` Metzger, Markus T
2016-07-20 14:32         ` Jan Kratochvil
2016-07-20 14:36         ` Pedro Alves [this message]
2016-07-20 14:39           ` Jan Kratochvil
2016-07-20 15:07             ` Pedro Alves
2016-07-21 13:51               ` Metzger, Markus T
2016-07-21 14:00                 ` Pedro Alves
2016-07-21 14:06                   ` Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b370d5c2-6dab-bcd4-be69-0d020a6019ec@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox