From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Markus Metzger <markus.t.metzger@intel.com>
Subject: [testsuite patch] Fix gdb.btrace/tailcall-only.exp errors on x86_64-m32
Date: Fri, 08 Apr 2016 15:53:00 -0000 [thread overview]
Message-ID: <20160408155331.GA31979@host1.jankratochvil.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]
Hi,
$ runtest 'CC_FOR_TARGET=gcc -m32' gdb.btrace/tailcall-only.exp
Running ./gdb.btrace/tailcall-only.exp ...
gdb compile failed, tailcall-only.c: Assembler messages:
tailcall-only.c:142: Error: cannot represent relocation type BFD_RELOC_64
[...]
tailcall-only.c:425: Error: cannot represent relocation type BFD_RELOC_64
It works for the other x86 arch combinations:
--- 20160406clean63-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m32.sum 2016-04-06 17:44:45.262849875 +0200
+++ 20160408clean67-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m32.sum 2016-04-08 17:40:49.739742759 +0200
#gdb.btrace/tailcall-only.exp
+Running gdb/testsuite/gdb.btrace/tailcall-only.exp ...
+gdb compile failed, tailcall-only.c: Assembler messages:
+tailcall-only.c:142: Error: cannot represent relocation type BFD_RELOC_64
[...]
+tailcall-only.c:425: Error: cannot represent relocation type BFD_RELOC_64
+UNTESTED: gdb.btrace/tailcall-only.exp: tailcall-only.exp
--- 20160406clean63-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m64.sum 2016-04-06 17:44:45.555852344 +0200
+++ 20160408clean67-fedora-rawhide//fedora-rawhide-x86_64/out/gdb-x86_64-redhat-linux-gnu-m64.sum 2016-04-08 17:40:50.021744759 +0200
#gdb.btrace/tailcall-only.exp
+Running gdb/testsuite/gdb.btrace/tailcall-only.exp ...
+PASS: gdb.btrace/tailcall-only.exp: set record function-call-history-size 0
[...]
+PASS: gdb.btrace/tailcall-only.exp: info frame
--- 20160406clean63-fedora-rawhide//fedora-rawhide-i386/out/gdb-i686-redhat-linux-gnu-m32.sum 2016-04-06 17:43:44.152334900 +0200
+++ 20160408clean67-fedora-rawhide//fedora-rawhide-i386/out/gdb-i686-redhat-linux-gnu-m32.sum 2016-04-08 17:40:04.451421514 +0200
#gdb.btrace/tailcall-only.exp
+Running gdb/testsuite/gdb.btrace/tailcall-only.exp ...
+PASS: gdb.btrace/tailcall-only.exp: set record function-call-history-size 0
[...]
+PASS: gdb.btrace/tailcall-only.exp: info frame
OK for check-in?
Jan
[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 889 bytes --]
gdb/testsuite/ChangeLog
2016-04-08 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.btrace/tailcall-only.exp: Use is_lp64_target check.
diff --git a/gdb/testsuite/gdb.btrace/tailcall-only.exp b/gdb/testsuite/gdb.btrace/tailcall-only.exp
index 44501f5..50837bf 100644
--- a/gdb/testsuite/gdb.btrace/tailcall-only.exp
+++ b/gdb/testsuite/gdb.btrace/tailcall-only.exp
@@ -35,9 +35,9 @@ if [info exists COMPILE] {
# make check RUNTESTFLAGS="gdb.btrace/tailcall-only.exp COMPILE=1"
standard_testfile tailcall-only.c
lappend opts debug optimize=-O2
-} elseif {[istarget "x86_64-*-*"]} {
+} elseif {[istarget "x86_64-*-*"] && [is_lp64_target]} {
standard_testfile x86_64-tailcall-only.S
-} elseif {[istarget "i?86-*-*"]} {
+} elseif {[istarget "i?86-*-*"] || [istarget "x86_64-*-*"]} {
standard_testfile i686-tailcall-only.S
} else {
verbose "Skipping ${testfile}."
next reply other threads:[~2016-04-08 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 15:53 Jan Kratochvil [this message]
2016-04-11 6:44 ` Metzger, Markus T
2016-04-11 19:55 ` Jan Kratochvil
2016-07-20 14:02 ` Pedro Alves
2016-07-20 14:22 ` [commit] " Jan Kratochvil
2016-07-20 14:26 ` Metzger, Markus T
2016-07-20 14:32 ` Jan Kratochvil
2016-07-20 14:36 ` Pedro Alves
2016-07-20 14:39 ` Jan Kratochvil
2016-07-20 15:07 ` Pedro Alves
2016-07-21 13:51 ` Metzger, Markus T
2016-07-21 14:00 ` Pedro Alves
2016-07-21 14:06 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408155331.GA31979@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox