From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <palves@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Cc: Laurent Morichetti <Laurent.Morichetti@amd.com>
Subject: Re: [PATCH] gdb: infrun: consume multiple events at each pass in stop_all_threads
Date: Thu, 16 Apr 2020 16:32:54 -0400 [thread overview]
Message-ID: <b35f4515-d0e8-33df-2b0a-cb7c2dcc1e4e@simark.ca> (raw)
In-Reply-To: <8402549f-c733-cb8b-918c-4dfb06eeb7a0@redhat.com>
On 2020-04-16 1:51 p.m., Pedro Alves via Gdb-patches wrote:
> This makes sense to me, but can you try locally to check whether
> if you do _more_ waits than wait_needed, like, say:
>
> for (int i = 0; i < (waits_needed * 2); i++)
>
> ... GDB still works correctly? In theory, wait_one will end up
> returning TARGET_WAITKIND_NO_RESUMED once you get to waits_needed,
> and things will all work out.
I've just tried it and this is what I observed.
> The reason I'm asking this, is if a process exits, or execs, while
> we're trying to stop it, I think that it's possible that we won't see
> an exit event for each and every thread of that exiting process.
> Particularly execs -- see follow_exec's delete_thread calls.
> This is somewhat related to Tankut's patch, here:
>
> https://sourceware.org/pipermail/gdb-patches/2020-April/167416.html
Hmm so his patch will definitely conflict with mine. I don't mind waiting
a bit and rebasing mine once his patch is merged, since he posted it long
before mine.
Simon
next prev parent reply other threads:[~2020-04-16 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 19:36 Simon Marchi
2020-03-11 19:13 ` Simon Marchi
2020-03-25 16:37 ` [PING][PATCH] " Simon Marchi
2020-04-16 17:51 ` [PATCH] " Pedro Alves
2020-04-16 20:32 ` Simon Marchi [this message]
2020-05-14 14:32 ` Aktemur, Tankut Baris
2020-05-14 18:02 ` [PATCH v2] " Simon Marchi
2020-05-14 18:14 ` Pedro Alves
2020-05-15 16:06 ` Simon Marchi
2020-05-15 16:15 ` Pedro Alves
2020-05-15 16:53 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35f4515-d0e8-33df-2b0a-cb7c2dcc1e4e@simark.ca \
--to=simark@simark.ca \
--cc=Laurent.Morichetti@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox