Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simark@simark.ca>,
	"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
	Simon Marchi <simon.marchi@efficios.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Laurent Morichetti <Laurent.Morichetti@amd.com>
Subject: Re: [PATCH v2] gdb: infrun: consume multiple events at each pass in stop_all_threads
Date: Thu, 14 May 2020 19:14:34 +0100	[thread overview]
Message-ID: <5ac9bb7a-6bf0-401f-909e-54d98739685b@palves.net> (raw)
In-Reply-To: <80775539-f358-874b-df16-1e8642e082ca@simark.ca>

On 5/14/20 7:02 PM, Simon Marchi wrote:

> Here's a rebased version.

Thanks Simon.  Please go ahead and merge.

BTW, did you consider coming up with a mechanism similar to
make_scoped_defer_target_commit_resume()/target_commit_resume()
for target_stop, so that we could coalesce the multiple vCont;t
requests in a single remote packet?  That could also cut down
on latency.

(gdbserver's resume interface is better for that, in that
a stop, continues and steps all go via the same interface:

 static void
 resume (struct thread_resume *actions, size_t num_actions)
 {

I've pondered adjusting GDB's resume interface in a similar
way.  That would make target_commit_resume Just Work for
stops too.
)

Thanks,
Pedro Alves


  reply	other threads:[~2020-05-14 18:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 19:36 [PATCH] " Simon Marchi
2020-03-11 19:13 ` Simon Marchi
2020-03-25 16:37   ` [PING][PATCH] " Simon Marchi
2020-04-16 17:51 ` [PATCH] " Pedro Alves
2020-04-16 20:32   ` Simon Marchi
2020-05-14 14:32     ` Aktemur, Tankut Baris
2020-05-14 18:02       ` [PATCH v2] " Simon Marchi
2020-05-14 18:14         ` Pedro Alves [this message]
2020-05-15 16:06           ` Simon Marchi
2020-05-15 16:15             ` Pedro Alves
2020-05-15 16:53               ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ac9bb7a-6bf0-401f-909e-54d98739685b@palves.net \
    --to=pedro@palves.net \
    --cc=Laurent.Morichetti@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=simon.marchi@efficios.com \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox