Re: [PATCH 5/5] gdb/dwarf: add unit_lists structure to index writer

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2026-01-20 12:00, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> I think it makes the code more readable than the pair of vector.  Also,
> Simon> I'm considering adding a third list (foreigh type units), which will be
> 
> Typo, "foreign"
> 
>  
> Simon> +struct unit_lists
> Simon> +{
> Simon> +  std::vector<const dwarf2_per_cu *> comp;
> Simon> +  std::vector<const signatured_type *> type;
> Simon> +};
> 
> I think it would be good to have comments here.
> 
> Tom

Is this good?

---

/* Lists of units, split by kind.  Each list is sorted by section offset.  */

struct unit_lists
{
  /* Compilation units.  */
  std::vector<const dwarf2_per_cu *> comp;

  /* Type units.  */
  std::vector<const signatured_type *> type;
};

---

Simon