From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] gdb/dwarf: add unit_lists structure to index writer
Date: Tue, 20 Jan 2026 10:00:06 -0700 [thread overview]
Message-ID: <87qzrk9q3t.fsf@tromey.com> (raw)
In-Reply-To: <20260117060335.691691-6-simon.marchi@polymtl.ca> (simon marchi's message of "Sat, 17 Jan 2026 01:02:35 -0500")
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
Simon> I think it makes the code more readable than the pair of vector. Also,
Simon> I'm considering adding a third list (foreigh type units), which will be
Typo, "foreign"
Simon> +struct unit_lists
Simon> +{
Simon> + std::vector<const dwarf2_per_cu *> comp;
Simon> + std::vector<const signatured_type *> type;
Simon> +};
I think it would be good to have comments here.
Tom
next prev parent reply other threads:[~2026-01-20 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-17 6:02 [PATCH 0/5] Some semi-random DWARF cleanups simon.marchi
2026-01-17 6:02 ` [PATCH 1/5] gdb/dwarf: merge one CU/TU code path simon.marchi
2026-01-17 6:02 ` [PATCH 2/5] gdb/dwarf: move DWP htab nullptr check to lookup_dwo_unit_in_dwp simon.marchi
2026-01-17 6:02 ` [PATCH 3/5] gdb/dwarf: add comments to debug_names::build simon.marchi
2026-01-17 6:02 ` [PATCH 4/5] gdb/dwarf: rename some abbrev-related things in debug_names writer simon.marchi
2026-01-17 6:02 ` [PATCH 5/5] gdb/dwarf: add unit_lists structure to index writer simon.marchi
2026-01-20 17:00 ` Tom Tromey [this message]
2026-01-20 17:33 ` Simon Marchi
2026-01-20 20:42 ` Tom Tromey
2026-01-20 21:12 ` Simon Marchi
2026-01-20 17:00 ` [PATCH 0/5] Some semi-random DWARF cleanups Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzrk9q3t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox