From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ia7VL/K0b2kb2wwAWB0awg (envelope-from ) for ; Tue, 20 Jan 2026 12:01:38 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=q76yPjha; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C0F621E08D; Tue, 20 Jan 2026 12:01:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 47ABD1E08D for ; Tue, 20 Jan 2026 12:01:38 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C39BB4BBCDFF for ; Tue, 20 Jan 2026 17:01:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C39BB4BBCDFF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=q76yPjha Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 25CAB4BBCDED for ; Tue, 20 Jan 2026 17:00:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25CAB4BBCDED Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25CAB4BBCDED Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768928409; cv=none; b=sSQ9KrjD+25nCESNdbxrpZU16MHRfDKu7cyahP0upr95Y5xQZuEUKjXiWWlln5sdHkkcmn+0rJMawakMoYiM0cIkfFZs5f3ddQZGKwsPa8/G0qUdr3jeZ42sxfTATA2MmU0BSLkflsQuoqzjNpQy6VxKzpGLvM06X2Bc4qislcg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768928409; c=relaxed/simple; bh=0n/pllpnZK8cxzriAjldPrJm3wYnQsl2XjGjjxvQbMQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rx+F6jWMqx0daV5AqGQLBNNYmt5sSKhOz4adZNKlYK1cJ2HT+Zd2l25VLHJPWOdu3FbmB5j6JM1Z9IOMB/AW7O70Z1ldFFSseM1gUqpLRhD0+OUBAnz1BYshm8Z/m6Jtoc+j6fdIHUcoY/scAQ7hUVoGVDy1fpS9iSo+xOj9KCk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25CAB4BBCDED Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id i3qWv88o0KXDJiF5MvMqcT; Tue, 20 Jan 2026 17:00:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id iF5LvYWYePL32iF5MvVk0w; Tue, 20 Jan 2026 17:00:08 +0000 X-Authority-Analysis: v=2.4 cv=MqhS63ae c=1 sm=1 tr=0 ts=696fb498 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=WuqUCp07B8wInZ376FYA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0NJjy6/Zzgg0pBIyWGh+JStyaqrgmrQYBMzDVSl6VS4=; b=q76yPjhahOqeg4v7cYV2PepuHp Kd6US6aNtpNPHF45SKUALoxDY7pfvza4wfp2rvsaMmqZUZOB5Hnx8nt5SPUeVLQoLewV/22LmHwC0 qz4pdbcnMg1S6EBrc6tJmva4E; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:57130 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1viF5L-00000002Nkm-3IkG; Tue, 20 Jan 2026 10:00:07 -0700 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] gdb/dwarf: add unit_lists structure to index writer In-Reply-To: <20260117060335.691691-6-simon.marchi@polymtl.ca> (simon marchi's message of "Sat, 17 Jan 2026 01:02:35 -0500") References: <20260117060335.691691-1-simon.marchi@polymtl.ca> <20260117060335.691691-6-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Tue, 20 Jan 2026 10:00:06 -0700 Message-ID: <87qzrk9q3t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1viF5L-00000002Nkm-3IkG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:57130 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDEh5xOztZYIF3w89FmoyaF0brCr4oTn7xoAr+PXtoVtoxG+GzlD6dewyVwksEB5sgTWzrzliZllcqcdY4eIGGsXoO7tIHXaKHFTmgJYoI6NSb1dH58e aAIVnCtb4R7KguP+vGYSHQaO0gk98AnsB6ap7cgVYBzsK+3enFh2AECaNlTUNT83YT5k8i6Noy5V/4kC3lk2IGImMRAEILI80YE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> I think it makes the code more readable than the pair of vector. Also, Simon> I'm considering adding a third list (foreigh type units), which will be Typo, "foreign" Simon> +struct unit_lists Simon> +{ Simon> + std::vector comp; Simon> + std::vector type; Simon> +}; I think it would be good to have comments here. Tom