From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RxPGHXO8b2nY5AwAWB0awg (envelope-from ) for ; Tue, 20 Jan 2026 12:33:39 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=nq4SFpuV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 68BB11E089; Tue, 20 Jan 2026 12:33:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BD5211E089 for ; Tue, 20 Jan 2026 12:33:38 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2B85B4BC7EC2 for ; Tue, 20 Jan 2026 17:33:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2B85B4BC7EC2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=nq4SFpuV Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D1F324BA900C for ; Tue, 20 Jan 2026 17:33:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1F324BA900C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1F324BA900C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768930388; cv=none; b=WoI8lxCpahBInekFRqLK9eGW3ReY3R5PcWx0Q2iWnH0vn3LYTLgEIk6app2Sctor+m9c2+tJNNEwHpxU8RRJrLx6SNfpE3mw0koXbNnBcyDsgQNS5jwJvPlZ6PjT7RPDtEq8/Adcm2eqF3G12r2EmyLZiKOUQn1fzasRwh5L8EE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768930388; c=relaxed/simple; bh=nsz8uGIwCFgm06HVdBceXqEMcqjJQf3vTZlCSme8XCk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WWaXC9Ze6ytzlxJe63WvAtPW246hu9/+Yt+SpNtAYcyYKhARRN5c6NewbUSWiJoUGk/VCz0tZ87lEAW28V49SBmsQaNpbMO8mpXkOHAxxKI8Kbqo5mkn6BGEM19pCwQpwrzXXcEFHMk9Bqvx1/Iv0i+aJW4dBEA21UEDLAGWPFs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D1F324BA900C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 60KHX2sY012512 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jan 2026 12:33:06 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 60KHX2sY012512 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1768930387; bh=j88enxwZ1tBg5x1FxniFeDgp+eRQPpErcwYru6ObsAY=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=nq4SFpuV+ix38+eorkLBehrayZirwaMlGwH6W5rds0Pd294/z3E/Q7TowfwiLZJT1 xq27XGR0TPz6xKgX9UtNlhiaviRJSjfT9exrWRiFIbkscgW98JASrQft+qFTPYqKsx dyP98BQa1bdV3xomScf8G7Y1X087rskVJ4XGP4vVsImcvENVr/u2YJgXpBmmWtCXk3 SJJwkf1RGWxEiIaAzCO5w0pV7S3WSFJF+BKCKquauOh+E6Kx82WAc0cmvjT+Impkdl D7sY86us0CnoIHRbWpYkVqSzu4EzTW30fL42EdZylGtBDgUtmBp9m+Zob9XhE0UoZg futMQKUq1mHxA== Received: by simark.ca (Postfix) id ECFCB1E089; Tue, 20 Jan 2026 12:33:01 -0500 (EST) Message-ID: Date: Tue, 20 Jan 2026 12:33:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] gdb/dwarf: add unit_lists structure to index writer To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260117060335.691691-1-simon.marchi@polymtl.ca> <20260117060335.691691-6-simon.marchi@polymtl.ca> <87qzrk9q3t.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87qzrk9q3t.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 20 Jan 2026 17:33:02 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-01-20 12:00, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> I think it makes the code more readable than the pair of vector. Also, > Simon> I'm considering adding a third list (foreigh type units), which will be > > Typo, "foreign" > > > Simon> +struct unit_lists > Simon> +{ > Simon> + std::vector comp; > Simon> + std::vector type; > Simon> +}; > > I think it would be good to have comments here. > > Tom Is this good? --- /* Lists of units, split by kind. Each list is sorted by section offset. */ struct unit_lists { /* Compilation units. */ std::vector comp; /* Type units. */ std::vector type; }; --- Simon