From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <aburgess@redhat.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Cc: Vasili Burdo <vasili.burdo@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb/tui/disassembly view: make symbol name appear on a line of its own
Date: Wed, 2 Feb 2022 09:33:09 -0500 [thread overview]
Message-ID: <b10a81f2-7387-021a-199e-06ad3916f33f@efficios.com> (raw)
In-Reply-To: <20220202134043.GG425591@redhat.com>
> Thanks for looking into this. I hadn't considered the page up/down
> case when I was looking for issues.
>
> I guess you'll post another version without the for_ui flag?
>
> Vasili, if you can find reproducers for the scrolling problems you are
> seeing then we should probably look into those separately.
Yes, I am looking into making a new version that handles better page
up/down. The thing is that we have to adjust
tui_find_disassembly_address to work with the fact that tui_disassemble
can sometimes produce 1 or 2 lines per disassembled address, this is not
trivial.
Simon
prev parent reply other threads:[~2022-02-02 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 19:28 Simon Marchi via Gdb-patches
2022-01-24 19:39 ` Vasili Burdo via Gdb-patches
2022-01-24 19:40 ` Simon Marchi via Gdb-patches
2022-01-28 22:41 ` Andrew Burgess via Gdb-patches
2022-01-29 1:20 ` Simon Marchi via Gdb-patches
2022-01-29 8:04 ` Vasili Burdo via Gdb-patches
2022-01-30 2:17 ` Simon Marchi via Gdb-patches
2022-02-02 13:40 ` Andrew Burgess via Gdb-patches
2022-02-02 14:33 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b10a81f2-7387-021a-199e-06ad3916f33f@efficios.com \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
--cc=vasili.burdo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox