From: Vasili Burdo via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Simon Marchi <simon.marchi@efficios.com>,
Andrew Burgess <aburgess@redhat.com>,
Vasili Burdo via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4] gdb/tui/disassembly view: make symbol name appear on a line of its own
Date: Sat, 29 Jan 2022 11:04:56 +0300 [thread overview]
Message-ID: <CANacp60o3w+=ULAaZn+nKGLqaymb19jZy-RxT6ZssEkdzbu8Fw@mail.gmail.com> (raw)
In-Reply-To: <b6809697-2ff5-b537-aca7-caa605250bb0@polymtl.ca>
Hi,
Vasili, if you happen to know why we have these
> two behaviors (for_ui and !for_ui), feel free to answer.
tui_disassembly() is used for 2 purposes: (1) on-screen text - ui, and (2)
for setting scroll position.
As I said before, I tried to use new-style disassembly for (2) and subtle
scrolling problems we have now became just worse.
The scrolling code is quite complex and hard to understand, so I decided to
use new style disassembly for UI only while keeping old style for anything
else. That's the reason for 'for-ui' flag.
next prev parent reply other threads:[~2022-01-29 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 19:28 Simon Marchi via Gdb-patches
2022-01-24 19:39 ` Vasili Burdo via Gdb-patches
2022-01-24 19:40 ` Simon Marchi via Gdb-patches
2022-01-28 22:41 ` Andrew Burgess via Gdb-patches
2022-01-29 1:20 ` Simon Marchi via Gdb-patches
2022-01-29 8:04 ` Vasili Burdo via Gdb-patches [this message]
2022-01-30 2:17 ` Simon Marchi via Gdb-patches
2022-02-02 13:40 ` Andrew Burgess via Gdb-patches
2022-02-02 14:33 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANacp60o3w+=ULAaZn+nKGLqaymb19jZy-RxT6ZssEkdzbu8Fw@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
--cc=vasili.burdo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox