From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uie1EVH19GEYHgAAWB0awg (envelope-from ) for ; Sat, 29 Jan 2022 03:05:37 -0500 Received: by simark.ca (Postfix, from userid 112) id BB84D1F3B4; Sat, 29 Jan 2022 03:05:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DB14B1F0E7 for ; Sat, 29 Jan 2022 03:05:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BBEF03857027 for ; Sat, 29 Jan 2022 08:05:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BBEF03857027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643443529; bh=odFG90dPGCz0xHNQFJQSgLXFoqU0J8jZO2d9zRJxiIo=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=igRS7A/hNdzLEKu+JehIh4Z04L7KcV/p07/6sMPEKTyQWcquNy6mDqDH4XGTx6FAs Wp4jnxsHRJ8PVdm+6b71F6fohN/18j2PRcV1u93Csq+2qiEC35bwlpLnnitI/F+hrV xDBi85WjldIg3zwL0I0xQf3pMKb8ubUsnDo2o+QI= Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by sourceware.org (Postfix) with ESMTPS id 58F543858D28 for ; Sat, 29 Jan 2022 08:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 58F543858D28 Received: by mail-vs1-xe2f.google.com with SMTP id f6so5777014vsa.5 for ; Sat, 29 Jan 2022 00:05:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tWFeuyBTYJ9Yc7WXBMjVx0qQWrclcOQaDzwB07RSWU4=; b=WbrIVxWw3QjOUCYV/kGbTq/OvwznLcL1+0nRlOc2+rmBBsV8qcBnjXKdQunNxnZL6+ dYuFmvM72c6JwhdAfMHxINFk0MQ6VgN+7OivLtQF0hCFYHd5H97EzVrrzX0h+CGRdpOX jbB1w0LsPrkqNaS1hCaO+YMAqONYIjBtjTp0SStiNKAH6gPWL9wiHIvdqNRm5Rt6ZGpr NtvzvuzpWmD+g9BAByvxSOCGC942lQ/W1FtUacm8qNTtvns92NWRjoGE6R9dfSjJCOq8 PZFYwRW+166Em/BTLPQaDikSSrHGsQbRixahaPtSzZvEzAIEqSnkpoXO3O7NMYzdl1qo biCA== X-Gm-Message-State: AOAM531vt7P3uamwp0qRQ8MBeXFHp9qUxxXl5ucxNN5E5N/JvqdAaOcQ qc4vH9YUNooDTWX1+fgsj3xBJas65fvvOZgb8Hc= X-Google-Smtp-Source: ABdhPJzgwELgmv+fmvPhx7bcSH3sVJzGlMorP22n7ILIZe8BM5ZuJJ+Nbr+0xY3EJJ1Tjlwx3zJmZB46vIMDZ8L+X0A= X-Received: by 2002:a67:c09a:: with SMTP id x26mr4708465vsi.26.1643443507955; Sat, 29 Jan 2022 00:05:07 -0800 (PST) MIME-Version: 1.0 References: <20220124192811.1530670-1-simon.marchi@polymtl.ca> <20220128224140.GF425591@redhat.com> In-Reply-To: Date: Sat, 29 Jan 2022 11:04:56 +0300 Message-ID: Subject: Re: [PATCH v4] gdb/tui/disassembly view: make symbol name appear on a line of its own To: Simon Marchi Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vasili Burdo via Gdb-patches Reply-To: Vasili Burdo Cc: Simon Marchi , Andrew Burgess , Vasili Burdo via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, Vasili, if you happen to know why we have these > two behaviors (for_ui and !for_ui), feel free to answer. tui_disassembly() is used for 2 purposes: (1) on-screen text - ui, and (2) for setting scroll position. As I said before, I tried to use new-style disassembly for (2) and subtle scrolling problems we have now became just worse. The scrolling code is quite complex and hard to understand, so I decided to use new style disassembly for UI only while keeping old style for anything else. That's the reason for 'for-ui' flag.