From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ipuCGjqW+mHdUwAAWB0awg (envelope-from ) for ; Wed, 02 Feb 2022 09:33:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 5BBCD1F3BA; Wed, 2 Feb 2022 09:33:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7974E1EE1A for ; Wed, 2 Feb 2022 09:33:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEA91385AC22 for ; Wed, 2 Feb 2022 14:33:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEA91385AC22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643812408; bh=VeZgG071MxuhHWlalXj8EDc0+6OYJr4Ai2fSQszFY6I=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hP4a0SeQ5QWj3ABADxW+tqymwe6h3PFbkQuEcj4nz36Q9VcBAbOyaADfWG6x1rR3/ UVhLCTRaBGiXpgItT/XO5OjkuIUXMea9jvMLjQJmg+srubJMEAhl3O94dUZ6mYrEO5 92heI64l4TCQk1YiOZNNKhodBMx99Ah2+HM1AuXQ= Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id A8DDF3858C2C for ; Wed, 2 Feb 2022 14:33:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8DDF3858C2C Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 4B34334FA58; Wed, 2 Feb 2022 09:33:10 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id blrNZ11Jo3K9; Wed, 2 Feb 2022 09:33:09 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id B66AE34F763; Wed, 2 Feb 2022 09:33:09 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com B66AE34F763 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pGSaY9AhtZJn; Wed, 2 Feb 2022 09:33:09 -0500 (EST) Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by mail.efficios.com (Postfix) with ESMTPSA id 823FE34F937; Wed, 2 Feb 2022 09:33:09 -0500 (EST) Subject: Re: [PATCH v4] gdb/tui/disassembly view: make symbol name appear on a line of its own To: Andrew Burgess , Simon Marchi References: <20220124192811.1530670-1-simon.marchi@polymtl.ca> <20220128224140.GF425591@redhat.com> <4f2da361-5a93-ee17-9bb5-e13653fc02d6@polymtl.ca> <20220202134043.GG425591@redhat.com> Message-ID: Date: Wed, 2 Feb 2022 09:33:09 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220202134043.GG425591@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Vasili Burdo , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Thanks for looking into this. I hadn't considered the page up/down > case when I was looking for issues. > > I guess you'll post another version without the for_ui flag? > > Vasili, if you can find reproducers for the scrolling problems you are > seeing then we should probably look into those separately. Yes, I am looking into making a new version that handles better page up/down. The thing is that we have to adjust tui_find_disassembly_address to work with the fact that tui_disassemble can sometimes produce 1 or 2 lines per disassembled address, this is not trivial. Simon