[RFC]: win32-nat.c better handling of DLL relocation

["Raoul Gough" <RaoulGough@yahoo.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

win32-nat.c currently only passes the loaded address of the .text
section into symbol_file_add, which means that any symbols from .data
or .bss don't get fixed up properly. This patch fixes the problem by
calculating the load addresses of all sections known to bfd.

I recently posted a test case which demonstrates the relocation
problem in the "coffread.c extension" thread (message ID
avejk1$lv6$1@main.gmane.org, posted 7 Jan 2003 13:10:49 -0000). This
showed that gdb 5.2.1 didn't handle any DLL symbol relocations. The
current CVS version only handles the .text section. With this patch,
it handles all sections correctly.

Raoul Gough.

[-- Attachment #2: ChangeLog_entry.txt --]
[-- Type: text/plain, Size: 255 bytes --]

2003-01-10  Raoul Gough  <RaoulGough@yahoo.co.uk>

 	* win32-nat.c(get_relocated_section_addrs): New function. Find
	section load addresses for symbol handling in relocated DLLs.
	(solib_symbols_add): Open a bfd and call get_relocated_section_addrs.

[-- Attachment #3: win32-nat.c.diff --]
[-- Type: application/octet-stream, Size: 4401 bytes --]

Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.66
diff -c -p -r1.66 win32-nat.c
*** win32-nat.c	23 Nov 2002 02:49:45 -0000	1.66
--- win32-nat.c	11 Jan 2003 15:49:38 -0000
*************** child_clear_solibs (void)
*** 750,761 ****
    solib_end = &solib_start;
    max_dll_name_len = sizeof ("DLL Name") - 1;
  }
  
  /* Add DLL symbol information. */
  static struct objfile *
  solib_symbols_add (char *name, int from_tty, CORE_ADDR load_addr)
  {
!   struct section_addr_info section_addrs;
  
    /* The symbols in a dll are offset by 0x1000, which is the
       the offset from 0 of the first byte in an image - because
--- 750,816 ----
    solib_end = &solib_start;
    max_dll_name_len = sizeof ("DLL Name") - 1;
  }
+ \f
+ /* Get the loaded address of all sections, given that .text was loaded
+    at text_load. Assumes that all sections are subject to the same
+    relocation offset. Returns NULL if problems occur or if the
+    sections were not relocated. */
  
+ static struct section_addr_info *
+ get_relocated_section_addrs (bfd *abfd, CORE_ADDR text_load)
+ {
+   struct section_addr_info *result = NULL;
+   int section_count = bfd_count_sections (abfd);
+   asection *text_section = bfd_get_section_by_name (abfd, ".text");
+   CORE_ADDR text_vma;
+ 
+   if (!text_section)
+     {
+       /* Couldn't get the .text section. Weird. */
+     }
+ 
+   else if (text_load == (text_vma = bfd_get_section_vma (abfd, text_section)))
+     {
+       /* DLL wasn't relocated. */
+     }
+ 
+   else
+     {
+       /* Figure out all sections' loaded addresses. The offset here is
+ 	 such that taking a bfd_get_section_vma() result and adding
+ 	 offset will give the real load address of the section. */
+ 
+       CORE_ADDR offset = text_load - text_vma;
+ 
+       struct section_table *table_start = NULL;
+       struct section_table *table_end = NULL;
+       struct section_table *iter = NULL;
+ 
+       build_section_table (abfd, &table_start, &table_end);
+ 
+       for (iter = table_start; iter < table_end; ++iter)
+ 	{
+ 	  /* Relocated addresses. */
+ 	  iter->addr += offset;
+ 	  iter->endaddr += offset;
+ 	}
+ 
+       result = build_section_addr_info_from_section_table (table_start,
+ 							   table_end);
+ 
+       xfree (table_start);
+     }
+ 
+   return result;
+ }
+ \f
  /* Add DLL symbol information. */
  static struct objfile *
  solib_symbols_add (char *name, int from_tty, CORE_ADDR load_addr)
  {
!   struct section_addr_info *section_addrs_ptr = NULL;
!   static struct objfile *result = NULL;
!   bfd *abfd = NULL;
  
    /* The symbols in a dll are offset by 0x1000, which is the
       the offset from 0 of the first byte in an image - because
*************** solib_symbols_add (char *name, int from_
*** 764,773 ****
    if (!name || !name[0])
      return NULL;
  
!   memset (&section_addrs, 0, sizeof (section_addrs));
!   section_addrs.other[0].name = ".text";
!   section_addrs.other[0].addr = load_addr;
!   return safe_symbol_file_add (name, from_tty, &section_addrs, 0, OBJF_SHARED);
  }
  
  /* Load DLL symbol info. */
--- 819,864 ----
    if (!name || !name[0])
      return NULL;
  
!   abfd = bfd_openr (name, "pei-i386");
! 
!   if (!abfd)
!     {
!       /* pei failed - try pe */
!       abfd = bfd_openr (name, "pe-i386");
!     }
! 
!   if (abfd)
!     {
!       if (bfd_check_format (abfd, bfd_object))
! 	{
! 	  section_addrs_ptr = get_relocated_section_addrs (abfd, load_addr);
! 	}
! 
!       bfd_close (abfd);
!     }
! 
!   if (section_addrs_ptr)
!     {
!       result = safe_symbol_file_add (name, from_tty, section_addrs_ptr,
! 				     0, OBJF_SHARED);
! 
!       free_section_addr_info (section_addrs_ptr);
!     }
! 
!   else
!     {
!       /* Fallback on handling just the .text section. */
!       struct section_addr_info section_addrs;
! 
!       memset (&section_addrs, 0, sizeof (section_addrs));
!       section_addrs.other[0].name = ".text";
!       section_addrs.other[0].addr = load_addr;
! 
!       result = safe_symbol_file_add (name, from_tty, &section_addrs,
! 				     0, OBJF_SHARED);
!     }
! 
!   return result;
  }
  
  /* Load DLL symbol info. */