Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC]: win32-nat.c better handling of DLL relocation
Date: Sat, 11 Jan 2003 17:23:00 -0000	[thread overview]
Message-ID: <20030111172431.GA5683@redhat.com> (raw)
In-Reply-To: <avpefr$mp5$1@main.gmane.org>

On Sat, Jan 11, 2003 at 03:52:09PM -0000, Raoul Gough wrote:
>win32-nat.c currently only passes the loaded address of the .text
>section into symbol_file_add, which means that any symbols from .data
>or .bss don't get fixed up properly. This patch fixes the problem by
>calculating the load addresses of all sections known to bfd.
>
>I recently posted a test case which demonstrates the relocation
>problem in the "coffread.c extension" thread (message ID
>avejk1$lv6$1@main.gmane.org, posted 7 Jan 2003 13:10:49 -0000). This
>showed that gdb 5.2.1 didn't handle any DLL symbol relocations. The
>current CVS version only handles the .text section. With this patch,
>it handles all sections correctly.
>
>Raoul Gough.

>2003-01-10  Raoul Gough  <RaoulGough@yahoo.co.uk>
>
> 	* win32-nat.c(get_relocated_section_addrs): New function. Find
>	section load addresses for symbol handling in relocated DLLs.
>	(solib_symbols_add): Open a bfd and call get_relocated_section_addrs.

I took a quick glance.  Looks good.  Now we just need that pesky
assignment.

<idle musing>I wonder if there is some way to do all of this assignment stuff
electronically.  It seems silly that we still have to rely on paper for this
kind of thing.</idle musing>

cgf


  reply	other threads:[~2003-01-11 17:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-11 15:51 Raoul Gough
2003-01-11 17:23 ` Christopher Faylor [this message]
2003-01-11 18:18   ` Raoul Gough
2003-01-29 15:20   ` Christopher Faylor
2003-01-29 18:26     ` Raoul Gough
2003-02-06 19:31     ` Raoul Gough
2003-02-06 19:51       ` Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030111172431.GA5683@redhat.com \
    --to=cgf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox