From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: gdb-patches@sourceware.org
Cc: Jovan Dmitrovic <jovan.dmitrovic@htecgroup.com>,
Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
Milica Matic <milica.matic@htecgroup.com>,
"Maciej W. Rozycki" <macro@globalfoundries.com>
Subject: [PATCH 0/7] MIPS+testsuite: BLEZL stepping fix and associated test infrastructure
Date: Thu, 23 Jul 2026 19:52:42 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2607220148540.14485@angie.orcam.me.uk> (raw)
Hi,
This patch series is based on a buried bug fix extracted from a change
submitted to add MIPSr6 support, most recently posted at
<https://inbox.sourceware.org/gdb-patches/20250604123838.501596-3-jovan.dmitrovic@htecgroup.com/>,
that corrects the handling of single-stepping through the BLEZL MIPS II
instruction.
This fix begged for test coverage, as indeed does all the MIPS software
single-stepping infrastructure, so I have created a bunch of test cases
roughly based on the skeleton already provided with said MIPSr6 change,
however with extra feature checks to correctly enable individual tests
based on the target configuration chosen for the testsuite invocation and
target board's compatibility with the ISA required for test execution.
This in turn revealed a repeated pattern of feature check code across
numerous procedures in testsuite/lib/gdb.exp. Rather than adding a bunch
more, I chose to factor out the repeated pattern and build the new feature
checks around it. For illustration purposes I have converted the existing
`powerpc*-*-*' target feature checks I could verify with my POWER9 test
system.
Consequently this set of 7 changes has resulted, comprised of the new
generic procedure in 1/7, followed by the `powerpc*-*-*' updates in 2/7,
and then the MIPS changes in 3/7 through 7/7. Only MIPS I, MIPS II and
MIPS16 CPU branches are covered at this point. See individual change
descriptions for details. Authorship attributions are on the best
knowledge basis.
This patch set has been regression-tested with a `powerpc64le-linux-gnu'
native configuration using POWER9 hardware and with the `mips-linux-gnu'
and `mipsel-linux-gnu' targets, using real MIPS I, MIPS III and MIPS32r2
hardware, the latter with regular MIPS and MIPS16 test configurations.
Detailed logs were examined for correctness with respect to the tests
affected as well.
I request approval for the non-MIPS parts of the patch series; I can
self-approve the MIPS bits, though obviously I'm happy to address any
feedback.
Company copyright assignment with FSF is currently being sorted.
Maciej
next reply other threads:[~2026-07-23 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:52 Maciej W. Rozycki [this message]
2026-07-23 18:52 ` [PATCH 1/7] testsuite: Factor out target feature test template Maciej W. Rozycki
2026-07-23 18:52 ` [PATCH 2/7] PowerPC/testsuite: Reduce feature tests in terms of `allow_target_tests' Maciej W. Rozycki
2026-07-23 18:52 ` [PATCH 3/7] MIPS/testsuite: Verify MIPS I CPU branch stepping Maciej W. Rozycki
2026-07-23 18:53 ` [PATCH 4/7] MIPS: Correct BLEZL single-stepping Maciej W. Rozycki
2026-07-23 18:53 ` [PATCH 5/7] MIPS/testsuite: Verify MIPS II CPU branch stepping Maciej W. Rozycki
2026-07-23 18:53 ` [PATCH 6/7] MIPS/testsuite: Verify MIPS16 " Maciej W. Rozycki
2026-07-23 18:53 ` [PATCH 7/7] MIPS: Reorder a reference to "BGTZ, BGTZL" in `mips32_next_pc' Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2607220148540.14485@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=Djordje.Todorovic@htecgroup.com \
--cc=gdb-patches@sourceware.org \
--cc=jovan.dmitrovic@htecgroup.com \
--cc=macro@globalfoundries.com \
--cc=milica.matic@htecgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox