From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/
Date: Thu, 20 Jun 2013 15:27:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1306201624110.16287@tp.orcam.me.uk> (raw)
In-Reply-To: <51C305F0.90008@codesourcery.com>
On Thu, 20 Jun 2013, Yao Qi wrote:
> > > +uint32_t mips_linux_watch_get_num_valid (struct pt_watch_regs *regs);
> > > >+uint32_t mips_linux_watch_get_irw_mask (struct pt_watch_regs *regs,
> > > >+ int set);
> > > >+CORE_ADDR mips_linux_watch_get_watchlo (struct pt_watch_regs *regs,
> > > >+ int set);
> > The two prototypes above will fit in a single line each.
> >
>
> If we put the prototypes into a single line, the length exceeds the
> 74-character limit. This is the reason I moved parameter "set" to a new line.
> Shall we keep them as what they are now?
There's no 74-character limit for code, all you need is to stay within 79
columns. Did you apply the ChangeLog rule here?
Maciej
next prev parent reply other threads:[~2013-06-20 15:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 2:44 [PATCH 0/3] mips hardware watchpoint support in gdbserver Yao Qi
2013-05-30 2:44 ` [PATCH 2/3] Move mips hardware watchpoint stuff to common/ Yao Qi
2013-06-13 4:12 ` Yao Qi
2013-06-19 22:05 ` Maciej W. Rozycki
2013-06-20 14:21 ` Yao Qi
2013-06-20 15:27 ` Maciej W. Rozycki [this message]
2013-06-20 17:50 ` Joel Brobecker
2013-06-21 8:03 ` Maciej W. Rozycki
2013-06-21 15:55 ` Joel Brobecker
2013-05-30 2:44 ` [PATCH 1/3] Include asm/ptrace.h in mips-linux-nat.c Yao Qi
2013-06-13 17:49 ` Maciej W. Rozycki
2013-06-14 6:53 ` Yao Qi
2013-06-14 12:53 ` Maciej W. Rozycki
2013-06-20 19:40 ` Pedro Alves
2013-06-20 20:45 ` Maciej W. Rozycki
2013-06-21 14:58 ` Pedro Alves
2013-06-17 16:04 ` Maciej W. Rozycki
2013-05-30 2:44 ` [PATCH 3/3] MIPS h/w watchpoint in GDBserver Yao Qi
2013-06-13 8:20 ` Yao Qi
2013-06-13 13:09 ` Eli Zaretskii
2013-06-13 16:56 ` Pedro Alves
2013-06-19 22:22 ` Maciej W. Rozycki
2013-06-21 15:00 ` Pedro Alves
2013-05-30 12:29 ` [PATCH 0/3] mips hardware watchpoint support in gdbserver Maciej W. Rozycki
2013-05-30 18:06 ` Pedro Alves
2013-05-30 18:08 ` Pedro Alves
2013-06-29 3:11 ` [PATCH v2 0/5] " Yao Qi
2013-06-29 3:11 ` [PATCH 2/5] Include asm/ptrace.h in mips-linux-nat.c Yao Qi
2013-07-24 0:26 ` Maciej W. Rozycki
2013-07-28 0:43 ` Yao Qi
2013-06-29 3:11 ` [PATCH 3/5] Refactor " Yao Qi
2013-07-24 0:27 ` Maciej W. Rozycki
2013-07-28 0:44 ` Yao Qi
2013-06-29 3:11 ` [PATCH 5/5] MIPS GDBserver watchpoint Yao Qi
2013-06-29 15:20 ` Eli Zaretskii
2013-07-24 0:35 ` Maciej W. Rozycki
2013-07-25 0:17 ` Yao Qi
2013-07-25 21:20 ` Maciej W. Rozycki
2013-07-28 0:49 ` Yao Qi
2013-07-24 18:11 ` Pedro Alves
2013-06-29 3:11 ` [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver Yao Qi
2013-07-24 0:26 ` Maciej W. Rozycki
2013-07-24 14:04 ` Tom Tromey
2013-07-28 0:41 ` Yao Qi
2013-06-29 8:01 ` [PATCH 4/5] Move mips hardware watchpoint stuff to common/ Yao Qi
2013-07-24 0:31 ` Maciej W. Rozycki
2013-07-24 2:08 ` Yao Qi
2013-07-24 18:09 ` Pedro Alves
2013-07-25 0:07 ` Yao Qi
2013-07-25 21:17 ` Maciej W. Rozycki
2013-07-28 0:47 ` Yao Qi
2013-07-22 1:11 ` [PATCH v2 0/5] mips hardware watchpoint support in gdbserver Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1306201624110.16287@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox