From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 2/5] Include asm/ptrace.h in mips-linux-nat.c
Date: Sat, 29 Jun 2013 03:11:00 -0000 [thread overview]
Message-ID: <1372475427-24862-3-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1372475427-24862-1-git-send-email-yao@codesourcery.com>
Hi,
This patch is to include asm/ptrace.h in mips-linux-nat.c and wrap
some structures by "ifndef PTRACE_GET_WATCH_REGS" and "#endif" as a
fallback if watchpoint-related structures are not defined in kernel
header.
gdb:
2013-06-29 Yao Qi <yao@codesourcery.com>
* mips-linux-nat.c (MAX_DEBUG_REGISTER): Move it earlier in
the code.
(enum pt_watch_style): Remove.
(struct mips32_watch_regs, struct mips64_watch_regs): Remove.
(struct pt_watch_regs): Likewise.
[!PTRACE_GET_WATCH_REGS] (enum pt_watch_style): New.
[!PTRACE_GET_WATCH_REGS] (struct mips32_watch_regs): New.
[!PTRACE_GET_WATCH_REGS] (struct mips64_watch_regs): New.
[!PTRACE_GET_WATCH_REGS] (struct pt_watch_regs): New.
---
gdb/mips-linux-nat.c | 39 ++++++++++++++++++++++-----------------
1 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c
index d323a82..44d23a6 100644
--- a/gdb/mips-linux-nat.c
+++ b/gdb/mips-linux-nat.c
@@ -34,6 +34,7 @@
#include <sgidefs.h>
#include <sys/ptrace.h>
+#include <asm/ptrace.h>
#include "features/mips-linux.c"
#include "features/mips-dsp-linux.c"
@@ -460,31 +461,19 @@ mips_linux_read_description (struct target_ops *ops)
return have_dsp ? tdesc_mips64_dsp_linux : tdesc_mips64_linux;
}
-#ifndef PTRACE_GET_WATCH_REGS
-# define PTRACE_GET_WATCH_REGS 0xd0
-#endif
-
-#ifndef PTRACE_SET_WATCH_REGS
-# define PTRACE_SET_WATCH_REGS 0xd1
-#endif
-
-#define W_BIT 0
-#define R_BIT 1
-#define I_BIT 2
+#define MAX_DEBUG_REGISTER 8
-#define W_MASK (1 << W_BIT)
-#define R_MASK (1 << R_BIT)
-#define I_MASK (1 << I_BIT)
+/* If macro PTRACE_GET_WATCH_REGS is not defined, kernel header doesn't
+ have hardware watchpoint-related structures. Define them below. */
-#define IRW_MASK (I_MASK | R_MASK | W_MASK)
+#ifndef PTRACE_GET_WATCH_REGS
+# define PTRACE_GET_WATCH_REGS 0xd0
enum pt_watch_style {
pt_watch_style_mips32,
pt_watch_style_mips64
};
-#define MAX_DEBUG_REGISTER 8
-
/* A value of zero in a watchlo indicates that it is available. */
struct mips32_watch_regs
@@ -524,6 +513,22 @@ struct pt_watch_regs
};
};
+#endif
+
+#ifndef PTRACE_SET_WATCH_REGS
+# define PTRACE_SET_WATCH_REGS 0xd1
+#endif
+
+#define W_BIT 0
+#define R_BIT 1
+#define I_BIT 2
+
+#define W_MASK (1 << W_BIT)
+#define R_MASK (1 << R_BIT)
+#define I_MASK (1 << I_BIT)
+
+#define IRW_MASK (I_MASK | R_MASK | W_MASK)
+
/* -1 if the kernel and/or CPU do not support watch registers.
1 if watch_readback is valid and we can read style, num_valid
and the masks.
--
1.7.7.6
next prev parent reply other threads:[~2013-06-29 3:11 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 2:44 [PATCH 0/3] mips hardware watchpoint support in gdbserver Yao Qi
2013-05-30 2:44 ` [PATCH 2/3] Move mips hardware watchpoint stuff to common/ Yao Qi
2013-06-13 4:12 ` Yao Qi
2013-06-19 22:05 ` Maciej W. Rozycki
2013-06-20 14:21 ` Yao Qi
2013-06-20 15:27 ` Maciej W. Rozycki
2013-06-20 17:50 ` Joel Brobecker
2013-06-21 8:03 ` Maciej W. Rozycki
2013-06-21 15:55 ` Joel Brobecker
2013-05-30 2:44 ` [PATCH 1/3] Include asm/ptrace.h in mips-linux-nat.c Yao Qi
2013-06-13 17:49 ` Maciej W. Rozycki
2013-06-14 6:53 ` Yao Qi
2013-06-14 12:53 ` Maciej W. Rozycki
2013-06-20 19:40 ` Pedro Alves
2013-06-20 20:45 ` Maciej W. Rozycki
2013-06-21 14:58 ` Pedro Alves
2013-06-17 16:04 ` Maciej W. Rozycki
2013-05-30 2:44 ` [PATCH 3/3] MIPS h/w watchpoint in GDBserver Yao Qi
2013-06-13 8:20 ` Yao Qi
2013-06-13 13:09 ` Eli Zaretskii
2013-06-13 16:56 ` Pedro Alves
2013-06-19 22:22 ` Maciej W. Rozycki
2013-06-21 15:00 ` Pedro Alves
2013-05-30 12:29 ` [PATCH 0/3] mips hardware watchpoint support in gdbserver Maciej W. Rozycki
2013-05-30 18:06 ` Pedro Alves
2013-05-30 18:08 ` Pedro Alves
2013-06-29 3:11 ` [PATCH v2 0/5] " Yao Qi
2013-06-29 3:11 ` [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver Yao Qi
2013-07-24 0:26 ` Maciej W. Rozycki
2013-07-24 14:04 ` Tom Tromey
2013-07-28 0:41 ` Yao Qi
2013-06-29 3:11 ` [PATCH 5/5] MIPS GDBserver watchpoint Yao Qi
2013-06-29 15:20 ` Eli Zaretskii
2013-07-24 0:35 ` Maciej W. Rozycki
2013-07-25 0:17 ` Yao Qi
2013-07-25 21:20 ` Maciej W. Rozycki
2013-07-28 0:49 ` Yao Qi
2013-07-24 18:11 ` Pedro Alves
2013-06-29 3:11 ` [PATCH 3/5] Refactor in mips-linux-nat.c Yao Qi
2013-07-24 0:27 ` Maciej W. Rozycki
2013-07-28 0:44 ` Yao Qi
2013-06-29 3:11 ` Yao Qi [this message]
2013-07-24 0:26 ` [PATCH 2/5] Include asm/ptrace.h " Maciej W. Rozycki
2013-07-28 0:43 ` Yao Qi
2013-06-29 8:01 ` [PATCH 4/5] Move mips hardware watchpoint stuff to common/ Yao Qi
2013-07-24 0:31 ` Maciej W. Rozycki
2013-07-24 2:08 ` Yao Qi
2013-07-24 18:09 ` Pedro Alves
2013-07-25 0:07 ` Yao Qi
2013-07-25 21:17 ` Maciej W. Rozycki
2013-07-28 0:47 ` Yao Qi
2013-07-22 1:11 ` [PATCH v2 0/5] mips hardware watchpoint support in gdbserver Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372475427-24862-3-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox