From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13585 invoked by alias); 20 Jun 2013 15:26:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13560 invoked by uid 89); 20 Jun 2013 15:26:10 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 15:26:10 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UpgkS-0001IC-FJ from Maciej_Rozycki@mentor.com for gdb-patches@sourceware.org; Thu, 20 Jun 2013 08:26:08 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Jun 2013 08:26:08 -0700 Received: from [172.30.64.40] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Thu, 20 Jun 2013 16:26:06 +0100 Date: Thu, 20 Jun 2013 15:27:00 -0000 From: "Maciej W. Rozycki" To: Yao Qi CC: Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/ In-Reply-To: <51C305F0.90008@codesourcery.com> Message-ID: References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1369881867-11372-3-git-send-email-yao@codesourcery.com> <51B93F00.5090002@codesourcery.com> <51C305F0.90008@codesourcery.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-06/txt/msg00542.txt.bz2 On Thu, 20 Jun 2013, Yao Qi wrote: > > > +uint32_t mips_linux_watch_get_num_valid (struct pt_watch_regs *regs); > > > >+uint32_t mips_linux_watch_get_irw_mask (struct pt_watch_regs *regs, > > > >+ int set); > > > >+CORE_ADDR mips_linux_watch_get_watchlo (struct pt_watch_regs *regs, > > > >+ int set); > > The two prototypes above will fit in a single line each. > > > > If we put the prototypes into a single line, the length exceeds the > 74-character limit. This is the reason I moved parameter "set" to a new line. > Shall we keep them as what they are now? There's no 74-character limit for code, all you need is to stay within 79 columns. Did you apply the ChangeLog rule here? Maciej