From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>,
Doug Evans <dje@google.com>
Subject: Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
Date: Mon, 14 Nov 2011 13:18:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1111141310520.4191@tp.orcam.me.uk> (raw)
In-Reply-To: <201111120008.28672.pedro@codesourcery.com>
On Sat, 12 Nov 2011, Pedro Alves wrote:
> > Well, OOC I looked at the relevant source and the bug (and consequently
> > the fix) is quite obvious -- the debug registers are only actually pushed
> > down to hardware on data breakpoints and not execution breakpoints.
>
> Ugh, my fault...
Well, that happens sometimes and it just shows we do really need this
test case. :)
NB I have deliberately omitted the skip_hw_breakpoint_tests check here as
I think we should test the failure modes too. If a target does not
support hardware breakpoints, then it should handle any requests to use
one gracefully, which this test case will record as unsupported. If any
targets still score failures here, then they need to be investigated.
> > 2011-11-11 Maciej W. Rozycki <macro@codesourcery.com>
> >
> > gdb/
> > * i386-nat.c (i386_insert_hw_breakpoint): Call
> > i386_update_inferior_debug_regs.
> > (i386_remove_hw_breakpoint): Likewise.
>
> Okay. Thanks!
Committed now, thanks for the review.
Maciej
next prev parent reply other threads:[~2011-11-14 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 12:13 Maciej W. Rozycki
2011-11-11 17:08 ` Doug Evans
2011-11-11 17:43 ` Joel Brobecker
2011-11-11 18:59 ` Maciej W. Rozycki
2011-11-12 0:08 ` Pedro Alves
2011-11-14 13:18 ` Maciej W. Rozycki [this message]
2011-11-11 20:12 ` Maciej W. Rozycki
2011-12-08 15:33 ` Maciej W. Rozycki
2012-02-27 21:30 ` Ping: " Maciej W. Rozycki
2012-02-28 17:27 ` Pedro Alves
2012-02-28 19:49 ` Maciej W. Rozycki
2012-03-01 11:42 ` Pedro Alves
2012-03-01 21:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1111141310520.4191@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox