From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20000 invoked by alias); 14 Nov 2011 13:18:54 -0000 Received: (qmail 19992 invoked by uid 22791); 14 Nov 2011 13:18:53 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Nov 2011 13:18:40 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1RPwQp-0003VO-8T from Maciej_Rozycki@mentor.com ; Mon, 14 Nov 2011 05:18:39 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 14 Nov 2011 05:16:23 -0800 Received: from [172.30.2.224] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Mon, 14 Nov 2011 13:18:37 +0000 Date: Mon, 14 Nov 2011 13:18:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: , Joel Brobecker , Doug Evans Subject: Re: [PATCH] testsuite: Add (extensive) hardware breakpoint testing In-Reply-To: <201111120008.28672.pedro@codesourcery.com> Message-ID: References: <20111111174247.GF5390@adacore.com> <201111120008.28672.pedro@codesourcery.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00350.txt.bz2 On Sat, 12 Nov 2011, Pedro Alves wrote: > > Well, OOC I looked at the relevant source and the bug (and consequently > > the fix) is quite obvious -- the debug registers are only actually pushed > > down to hardware on data breakpoints and not execution breakpoints. > > Ugh, my fault... Well, that happens sometimes and it just shows we do really need this test case. :) NB I have deliberately omitted the skip_hw_breakpoint_tests check here as I think we should test the failure modes too. If a target does not support hardware breakpoints, then it should handle any requests to use one gracefully, which this test case will record as unsupported. If any targets still score failures here, then they need to be investigated. > > 2011-11-11 Maciej W. Rozycki > > > > gdb/ > > * i386-nat.c (i386_insert_hw_breakpoint): Call > > i386_update_inferior_debug_regs. > > (i386_remove_hw_breakpoint): Likewise. > > Okay. Thanks! Committed now, thanks for the review. Maciej