From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
Date: Thu, 01 Mar 2012 11:42:00 -0000 [thread overview]
Message-ID: <4F4F6079.5040907@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1202281934340.4811@tp.orcam.me.uk>
On 02/28/2012 07:42 PM, Maciej W. Rozycki wrote:
> On Tue, 28 Feb 2012, Pedro Alves wrote:
>>> +if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } {
>>
>> s/"break"/"hbreak2", so that running this test doesn't overwrite break.exp's binary.
>> More instances of this.
>
> Good point, apparently there is just one other place requiring this
> adjustment.
I've added this to the testcase cookbook at <http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.
>
> Thanks for your review, here's the resulting update. Any further
> thoughts, anyone?
Not from me. Thanks for doing this.
--
Pedro Alves
next prev parent reply other threads:[~2012-03-01 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 12:13 Maciej W. Rozycki
2011-11-11 17:08 ` Doug Evans
2011-11-11 17:43 ` Joel Brobecker
2011-11-11 18:59 ` Maciej W. Rozycki
2011-11-12 0:08 ` Pedro Alves
2011-11-14 13:18 ` Maciej W. Rozycki
2011-11-11 20:12 ` Maciej W. Rozycki
2011-12-08 15:33 ` Maciej W. Rozycki
2012-02-27 21:30 ` Ping: " Maciej W. Rozycki
2012-02-28 17:27 ` Pedro Alves
2012-02-28 19:49 ` Maciej W. Rozycki
2012-03-01 11:42 ` Pedro Alves [this message]
2012-03-01 21:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4F6079.5040907@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox