Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix -Wmisleading-indentation warning in top.c
Date: Wed, 18 Dec 2019 16:43:00 -0000	[thread overview]
Message-ID: <adab572f-25e6-7d72-284d-bb8ff8f3da8f@redhat.com> (raw)
In-Reply-To: <20191216235818.10307-1-simon.marchi@efficios.com>

On 12/16/19 11:58 PM, Simon Marchi wrote:

> This looks like a legitimate warning, the fprintf_filtered is too much
> indented.  Fix it, and at the same time add a bit of whitespace to make
> this function easier to read.

Thanks for the extra whitespace.  I agree it helps.

> 
> gdb/ChangeLog:
> 
> 	* top.c (print_gdb_configuration): Adjust indentation.

OK.

> +  /* We assume "relocatable" will be printed at least once, thus we always
> +     print this text.  It's a reasonably safe assumption for now.  */
> +  fprintf_filtered (stream, _("\n\
>  (\"Relocatable\" means the directory can be moved with the GDB installation\n\
>  tree, and GDB will still find it.)\n\
>  "));
> 

Sounds like GCC should catch this too.

Thanks,
Pedro Alves


  reply	other threads:[~2019-12-18 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 23:58 Simon Marchi
2019-12-18 16:43 ` Pedro Alves [this message]
2019-12-18 17:10   ` Pedro Alves
2019-12-18 17:28     ` Simon Marchi
2019-12-18 18:41     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adab572f-25e6-7d72-284d-bb8ff8f3da8f@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox