Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix -Wmisleading-indentation warning in top.c
Date: Wed, 18 Dec 2019 17:28:00 -0000	[thread overview]
Message-ID: <fdf2ec50-b0e1-7ad4-9bec-66ee9ca91598@efficios.com> (raw)
In-Reply-To: <86a9852f-eb6d-521f-7efc-0da48bc0ebee@redhat.com>

On 2019-12-18 12:10 p.m., Pedro Alves wrote:
> On 12/18/19 4:42 PM, Pedro Alves wrote:
> 
>> Sounds like GCC should catch this too.
> 
> It looks like it's the continuation line that prevents it.  Here's
> a minimal reproducer:
> 
> void print (const char *);
> 
> void function1 (void)
> {
>   if (1)
>     print ("\n");
>     print ("\n"); // warns
> }
> 
> void function2 (void)
> {
>   if (1)
>     print ("hello\
> \n");
>     print ("\n"); // does not warn
> }
> 
> I'll file a bug.
> 
> Thanks,
> Pedro Alves
> 

Oh, thanks a lot for doing this, I should have done it in the first place...

I pushed the patch.

Simon


  reply	other threads:[~2019-12-18 17:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 23:58 Simon Marchi
2019-12-18 16:43 ` Pedro Alves
2019-12-18 17:10   ` Pedro Alves
2019-12-18 17:28     ` Simon Marchi [this message]
2019-12-18 18:41     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdf2ec50-b0e1-7ad4-9bec-66ee9ca91598@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox