From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10872 invoked by alias); 18 Dec 2019 16:43:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10816 invoked by uid 89); 18 Dec 2019 16:43:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Dec 2019 16:43:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576687386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhv4CNvoJjyfFOeTDp0q5MSO8252kTNaQKC6yNLWnWo=; b=chgBEi0SWEdulGRiUZ5NZYcy9xZzkhpR0qt3VIXk+EMY4rcXY/5hrg+0qxZNNNz3v06EsJ HxO5IBu+IhH2awqRrZIGmu0vCe82QdQD/DUwn8EdTrsxsWwZtTeP6WuNtoMesxWp0OVQcF owyiL6vRZALVtfhrt3ssoImjM0mD7Lo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-AW2o679SNk-GvAN9b15CSA-1; Wed, 18 Dec 2019 11:43:02 -0500 Received: by mail-wm1-f70.google.com with SMTP id m133so690908wmf.2 for ; Wed, 18 Dec 2019 08:43:02 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a5sm2970013wmb.37.2019.12.18.08.43.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2019 08:43:00 -0800 (PST) Subject: Re: [PATCH] Fix -Wmisleading-indentation warning in top.c To: Simon Marchi , gdb-patches@sourceware.org References: <20191216235818.10307-1-simon.marchi@efficios.com> From: Pedro Alves Message-ID: Date: Wed, 18 Dec 2019 16:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20191216235818.10307-1-simon.marchi@efficios.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00768.txt.bz2 On 12/16/19 11:58 PM, Simon Marchi wrote: > This looks like a legitimate warning, the fprintf_filtered is too much > indented. Fix it, and at the same time add a bit of whitespace to make > this function easier to read. Thanks for the extra whitespace. I agree it helps. > > gdb/ChangeLog: > > * top.c (print_gdb_configuration): Adjust indentation. OK. > + /* We assume "relocatable" will be printed at least once, thus we always > + print this text. It's a reasonably safe assumption for now. */ > + fprintf_filtered (stream, _("\n\ > (\"Relocatable\" means the directory can be moved with the GDB installation\n\ > tree, and GDB will still find it.)\n\ > ")); > Sounds like GCC should catch this too. Thanks, Pedro Alves