Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb, testsuite, btrace: relax unneeded stepi expected output
Date: Thu, 1 Apr 2021 13:54:12 -0300	[thread overview]
Message-ID: <acdde964-74f9-9838-26c3-b4b091ded8ce@linaro.org> (raw)
In-Reply-To: <20210316092637.935739-1-markus.t.metzger@intel.com>

On 3/16/21 6:26 AM, Markus Metzger via Gdb-patches wrote:
> In gdb.btrace/reconnect.exp, we test that we can disconnect and reconnect
> again to a GDB session that is recording with the btrace recording format.
> It does not really matter what we are recording.
> 
> The test assumed that stepping from _start will bring us into an area
> without debug information.  This is not correct on all systems.
> 
> Relax the expected output to also support systems where we do have debug
> information for that code.
> 
> gdb/testsuite/ChangeLog:
> 2021-03-08  Markus Metzger  <markus.t.metzger@intel.com>
> 
> 	* gdb.btrace/reconnect.exp: Relax expected stepi output.
> ---
>   gdb/testsuite/gdb.btrace/reconnect.exp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btrace/reconnect.exp
> index 2e61d3591f3..26578706eaf 100644
> --- a/gdb/testsuite/gdb.btrace/reconnect.exp
> +++ b/gdb/testsuite/gdb.btrace/reconnect.exp
> @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
>   # Create a record, check, reconnect
>   with_test_prefix "first" {
>     gdb_test_no_output "record btrace" "record btrace enable"
> -  gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)"
> +  gdb_test "stepi 19" ".*"
>   
>     gdb_test "info record" [multi_line \
>       "Active record target: .*" \
> 

Investigating some racy tests under make check-read1, isn't there a 
better matching pattern that we can use here to prevent future 
non-determinism?

  parent reply	other threads:[~2021-04-01 16:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16  9:26 Markus Metzger via Gdb-patches
2021-04-01 16:44 ` Tom Tromey
2021-04-01 16:54 ` Luis Machado via Gdb-patches [this message]
2021-04-12  8:22   ` Metzger, Markus T via Gdb-patches
2021-04-12 11:05     ` Luis Machado via Gdb-patches
2021-04-12 11:09       ` Metzger, Markus T via Gdb-patches
2021-04-12 11:11         ` Luis Machado via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acdde964-74f9-9838-26c3-b4b091ded8ce@linaro.org \
    --to=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox