From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aEwgK7v6ZWA5NAAAWB0awg (envelope-from ) for ; Thu, 01 Apr 2021 12:54:19 -0400 Received: by simark.ca (Postfix, from userid 112) id AE7881EF4F; Thu, 1 Apr 2021 12:54:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A3E4B1E783 for ; Thu, 1 Apr 2021 12:54:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5354F3846033; Thu, 1 Apr 2021 16:54:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5354F3846033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617296058; bh=CaWjo9uAf+Pb0ujb1i9zhItpPjn2IwrLnRKZ7MDaxlk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KczqGqGfdlveD4j5UgP9TjdckUwCsFMf5nOqwt6SVprwooEQ7Npkv1UCX3GwZG3HB W8uF+dQBawUTn5aXs8ZiljDiY6Js6oIlPuU7+4sg2IK4SSvEDzsVHPf7lmWQiCM1jP 3bRkLo+OL+bt9wDIVF5FFP4BrQ2nNpv4ugG+CDrg= Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by sourceware.org (Postfix) with ESMTPS id 076343858024 for ; Thu, 1 Apr 2021 16:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 076343858024 Received: by mail-qk1-x736.google.com with SMTP id 7so2829687qka.7 for ; Thu, 01 Apr 2021 09:54:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CaWjo9uAf+Pb0ujb1i9zhItpPjn2IwrLnRKZ7MDaxlk=; b=HkbhAPFO4xydfc3LcWGI+TD832EI1EBELPgN/xzEsSDL/5iBhDrmfO9CTnn4FNPdOg nz7cJscWqxh8D4uufPplrynYue1dQErauB5L0PZnUbEDVwAzgzOQoWGSSdebTA17wFiq ji4peZLSbn95EQyeF9hHGLgm6sfGKu5clbC8Gk/NBRUu4COrDpOnUG8pBKbStypdEIxC yh90mcQIo8QogOL44n6s3ov8Sjgy+qu1+htUgzYwFMGgLchpNu2Fr1oWaCTFFHy2j1h3 flrkIn89TerSos8hf+0hf7GlGw+xZZIpa/vS/085v5SfTTlZnpVd1VUHo0g8D8iNKsZ6 RlxA== X-Gm-Message-State: AOAM532yid54BtQXaB4T93PKidFBcEXCwkjJCxoAGYec5TaxXTl3GGBO OS7dEnIZS319/FGPhCILqTKUA1GljPcfzQ== X-Google-Smtp-Source: ABdhPJyOwBd+Kn24O3ijn8tVZTiYbEobbfKxXvUGMjlLMDA0Q1CzB7PcqKW6CrKRxsdALrmbB8MkIQ== X-Received: by 2002:a05:620a:a12:: with SMTP id i18mr9223606qka.119.1617296055555; Thu, 01 Apr 2021 09:54:15 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:a9:4096:7e03:e64d? ([2804:7f0:4841:2841:a9:4096:7e03:e64d]) by smtp.gmail.com with ESMTPSA id p5sm4467044qkj.35.2021.04.01.09.54.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 09:54:15 -0700 (PDT) Subject: Re: [PATCH] gdb, testsuite, btrace: relax unneeded stepi expected output To: Markus Metzger , gdb-patches@sourceware.org References: <20210316092637.935739-1-markus.t.metzger@intel.com> Message-ID: Date: Thu, 1 Apr 2021 13:54:12 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210316092637.935739-1-markus.t.metzger@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 3/16/21 6:26 AM, Markus Metzger via Gdb-patches wrote: > In gdb.btrace/reconnect.exp, we test that we can disconnect and reconnect > again to a GDB session that is recording with the btrace recording format. > It does not really matter what we are recording. > > The test assumed that stepping from _start will bring us into an area > without debug information. This is not correct on all systems. > > Relax the expected output to also support systems where we do have debug > information for that code. > > gdb/testsuite/ChangeLog: > 2021-03-08 Markus Metzger > > * gdb.btrace/reconnect.exp: Relax expected stepi output. > --- > gdb/testsuite/gdb.btrace/reconnect.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btrace/reconnect.exp > index 2e61d3591f3..26578706eaf 100644 > --- a/gdb/testsuite/gdb.btrace/reconnect.exp > +++ b/gdb/testsuite/gdb.btrace/reconnect.exp > @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport > # Create a record, check, reconnect > with_test_prefix "first" { > gdb_test_no_output "record btrace" "record btrace enable" > - gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)" > + gdb_test "stepi 19" ".*" > > gdb_test "info record" [multi_line \ > "Active record target: .*" \ > Investigating some racy tests under make check-read1, isn't there a better matching pattern that we can use here to prevent future non-determinism?