Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Metzger, Markus T via Gdb-patches" <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH] gdb, testsuite, btrace: relax unneeded stepi expected output
Date: Mon, 12 Apr 2021 11:09:43 +0000	[thread overview]
Message-ID: <DM5PR11MB1690D73238D59E46751AF411DE709@DM5PR11MB1690.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b2043b7a-6a26-1929-e0ea-aab88435c5dd@linaro.org>

Hello Luis,

>>>> @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol
>$gdbserver_gdbport
>>>>    # Create a record, check, reconnect
>>>>    with_test_prefix "first" {
>>>>      gdb_test_no_output "record btrace" "record btrace enable"
>>>> -  gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)"
>>>> +  gdb_test "stepi 19" ".*"
>>>>
>>>>      gdb_test "info record" [multi_line \
>>>>        "Active record target: .*" \
>>>>
>>>
>>> Investigating some racy tests under make check-read1, isn't there a
>>> better matching pattern that we can use here to prevent future
>>> non-determinism?
>>
>> The test now ignores all output since it doesn't really matter where we end up
>> after stepping.  This should be the most future-proof pattern.  Were you
>looking
>> for a less lax pattern?
>
>Yeah, I was looking for a more meaningful kind of test other than
>expecting anything.

The meaningful part is just outside of this hunk:

  gdb_test "info record" [multi_line \
    "Active record target: .*" \
    "Recorded 19 instructions in .+ functions \\(. gaps\\) for thread 1 \\(Thread .*\\)."
  ]

We check that we actually stepped exactly those 19 instructions.  The test doesn't
care where this brought us.

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2021-04-12 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16  9:26 Markus Metzger via Gdb-patches
2021-04-01 16:44 ` Tom Tromey
2021-04-01 16:54 ` Luis Machado via Gdb-patches
2021-04-12  8:22   ` Metzger, Markus T via Gdb-patches
2021-04-12 11:05     ` Luis Machado via Gdb-patches
2021-04-12 11:09       ` Metzger, Markus T via Gdb-patches [this message]
2021-04-12 11:11         ` Luis Machado via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB1690D73238D59E46751AF411DE709@DM5PR11MB1690.namprd11.prod.outlook.com \
    --to=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox