Re: [PATCH] testsuite: disable break-interp.exp for Arm buildbot

[Pedro Alves <palves@redhat.com>]

On 8/9/19 10:21 AM, Alan Hayward wrote:

> Use this test to disable gdb.base/break-interp.exp, 

I'd rather avoid completely skipping silently, since this way 
nobody will ever remember to enable it back.

> as this test currently generates 132 sequential timeouts.

So, in the general case, when something like that happens, it's better
to make the testcase bail out earlier in response to one of the
failures.  Like, if we fail to run to a breakpoint or something, then
there's no point in continuing the parts of the testcase that depend
on running to that breakpoint.

Is there some fundamental failures in each of the iterations of
the test that we could detect to skip most of the tests in each of
the iterations?

From your mention of "fix stop on solib" not working, it sounds like the
trouble is that when the testcase does "set stop-on-solib-events 1 + run",
the inferior never stops and we time out.  Can you make reach_1 detect it
and bail out without waiting for a time out?  Like, make the testcase
put a breakpoint somewhere in case stop-on-solib-events fails to stop
the inferior.

That'd be better since it'd record the FAILs, and it would be target
independent.

Some minor comments below.

> diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.base/break-interp.exp
> index d6da653529..6a366db49f 100644
> --- a/gdb/testsuite/gdb.base/break-interp.exp
> +++ b/gdb/testsuite/gdb.base/break-interp.exp
> @@ -15,7 +15,8 @@
>  
>  # This test only works on GNU/Linux.
>  if { ![isnative] || [is_remote host] || [use_gdb_stub]
> -     || ![istarget *-linux*] || [skip_shlib_tests]} {
> +     || ![istarget *-linux*] || [skip_shlib_tests]
> +     || [is_aarch32_on_aarch64_target]} {
>      continue
>  }

ENOCOMMENTS.

>  
> diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
> index 122e652858..d43dd95904 100644
> --- a/gdb/testsuite/lib/future.exp
> +++ b/gdb/testsuite/lib/future.exp
> @@ -172,6 +172,16 @@ proc gdb_find_eu-unstrip {} {
>      return $eu_unstrip
>  }
>  
> +proc gdb_find_uname {} {
> +    global UNAME_FOR_TARGET
> +    if [info exists UNAME_FOR_TARGET] {
> +	set uname $UNAME_FOR_TARGET
> +    } else {
> +	set uname [transform uname]
> +    }
> +    return $uname
> +}
> +
Not sure this should be here.  See the comment at the
top of the file.

Thanks,
Pedro Alves