From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55823 invoked by alias); 9 Aug 2019 17:22:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55815 invoked by uid 89); 9 Aug 2019 17:22:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 17:22:15 +0000 Received: by mail-wm1-f65.google.com with SMTP id m125so2221348wmm.3 for ; Fri, 09 Aug 2019 10:22:15 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id o16sm8240008wrp.23.2019.08.09.10.22.12 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 09 Aug 2019 10:22:13 -0700 (PDT) Subject: Re: [PATCH] testsuite: disable break-interp.exp for Arm buildbot To: Alan Hayward , "gdb-patches@sourceware.org" References: <20190809092128.94802-1-alan.hayward@arm.com> Cc: nd From: Pedro Alves Message-ID: Date: Fri, 09 Aug 2019 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190809092128.94802-1-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00232.txt.bz2 On 8/9/19 10:21 AM, Alan Hayward wrote: > Use this test to disable gdb.base/break-interp.exp, I'd rather avoid completely skipping silently, since this way nobody will ever remember to enable it back. > as this test currently generates 132 sequential timeouts. So, in the general case, when something like that happens, it's better to make the testcase bail out earlier in response to one of the failures. Like, if we fail to run to a breakpoint or something, then there's no point in continuing the parts of the testcase that depend on running to that breakpoint. Is there some fundamental failures in each of the iterations of the test that we could detect to skip most of the tests in each of the iterations? >From your mention of "fix stop on solib" not working, it sounds like the trouble is that when the testcase does "set stop-on-solib-events 1 + run", the inferior never stops and we time out. Can you make reach_1 detect it and bail out without waiting for a time out? Like, make the testcase put a breakpoint somewhere in case stop-on-solib-events fails to stop the inferior. That'd be better since it'd record the FAILs, and it would be target independent. Some minor comments below. > diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.base/break-interp.exp > index d6da653529..6a366db49f 100644 > --- a/gdb/testsuite/gdb.base/break-interp.exp > +++ b/gdb/testsuite/gdb.base/break-interp.exp > @@ -15,7 +15,8 @@ > > # This test only works on GNU/Linux. > if { ![isnative] || [is_remote host] || [use_gdb_stub] > - || ![istarget *-linux*] || [skip_shlib_tests]} { > + || ![istarget *-linux*] || [skip_shlib_tests] > + || [is_aarch32_on_aarch64_target]} { > continue > } ENOCOMMENTS. > > diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp > index 122e652858..d43dd95904 100644 > --- a/gdb/testsuite/lib/future.exp > +++ b/gdb/testsuite/lib/future.exp > @@ -172,6 +172,16 @@ proc gdb_find_eu-unstrip {} { > return $eu_unstrip > } > > +proc gdb_find_uname {} { > + global UNAME_FOR_TARGET > + if [info exists UNAME_FOR_TARGET] { > + set uname $UNAME_FOR_TARGET > + } else { > + set uname [transform uname] > + } > + return $uname > +} > + Not sure this should be here. See the comment at the top of the file. Thanks, Pedro Alves