Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	nd <nd@arm.com>
Subject: Re: [PATCH] testsuite: disable break-interp.exp for Arm buildbot
Date: Mon, 12 Aug 2019 15:53:00 -0000	[thread overview]
Message-ID: <6B4E82F7-FCBE-46CC-8769-99C615D80F7E@arm.com> (raw)
In-Reply-To: <abb5717f-91d5-7be0-2457-3f46de87324e@redhat.com>



> On 9 Aug 2019, at 18:22, Pedro Alves <palves@redhat.com> wrote:
> 
> On 8/9/19 10:21 AM, Alan Hayward wrote:
> 
>> Use this test to disable gdb.base/break-interp.exp, 
> 
> I'd rather avoid completely skipping silently, since this way 
> nobody will ever remember to enable it back.
> 
>> as this test currently generates 132 sequential timeouts.
> 
> So, in the general case, when something like that happens, it's better
> to make the testcase bail out earlier in response to one of the
> failures.  Like, if we fail to run to a breakpoint or something, then
> there's no point in continuing the parts of the testcase that depend
> on running to that breakpoint.
> 
> Is there some fundamental failures in each of the iterations of
> the test that we could detect to skip most of the tests in each of
> the iterations?
> 
> From your mention of "fix stop on solib" not working, it sounds like the
> trouble is that when the testcase does "set stop-on-solib-events 1 + run",
> the inferior never stops and we time out.  Can you make reach_1 detect it
> and bail out without waiting for a time out?  Like, make the testcase
> put a breakpoint somewhere in case stop-on-solib-events fails to stop
> the inferior.
> 
> That'd be better since it'd record the FAILs, and it would be target
> independent.
> 

Agreed. It’s not quite that simple - the failures happen in cases where there
is no debug (eg BINprelinkNOdebugNOpieNO), so there is nowhere I can place
a breakpoint.

Maybe exit the test case if one of them times out?  (I’m not keen on that either).


Alan.


  reply	other threads:[~2019-08-12 15:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  9:21 Alan Hayward
2019-08-09 17:22 ` Pedro Alves
2019-08-12 15:53   ` Alan Hayward [this message]
2019-08-15 17:49     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6B4E82F7-FCBE-46CC-8769-99C615D80F7E@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox