From: Patrick Monnerat via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling
Date: Sun, 15 Aug 2021 02:30:02 +0200 [thread overview]
Message-ID: <aa262ca5-ddbc-80a9-e564-40e3e5093bcb@monnerat.net> (raw)
In-Reply-To: <3002b4db-52a4-b7a5-ca1a-49398ba439ed@polymtl.ca>
On 8/14/21 6:05 AM, Simon Marchi wrote:
> I looked at the change a bit more in depth, in particular at the various
> observers of breakpoint_modified. One of them is MI, who prints the
> =breakpoint-modified notification.
Good catch !
> if I run a program with a breakpoint with "enable
> count 1 1", the notification I get without your patch is:
>
> =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="n",...
> ^
> And with the patch:
>
> =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="y",
> ^
You probably mean the other way round...
Next patch post will contain tests according to your advices.
Many thanks for your hints and your work on this.
Patrick
next prev parent reply other threads:[~2021-08-15 0:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 22:24 Patrick Monnerat via Gdb-patches
2021-08-14 4:05 ` Simon Marchi via Gdb-patches
2021-08-15 0:30 ` Patrick Monnerat via Gdb-patches [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-16 12:44 Patrick Monnerat via Gdb-patches
2021-08-16 14:04 ` Simon Marchi via Gdb-patches
2021-08-16 14:09 ` Patrick Monnerat via Gdb-patches
2021-08-16 15:10 ` Simon Marchi via Gdb-patches
2021-08-16 16:18 ` Patrick Monnerat via Gdb-patches
2021-08-15 0:33 Patrick Monnerat via Gdb-patches
2021-08-16 1:32 ` Simon Marchi via Gdb-patches
2021-08-13 15:31 Patrick Monnerat via Gdb-patches
2021-08-13 15:45 ` Simon Marchi via Gdb-patches
2021-08-13 16:27 ` Patrick Monnerat via Gdb-patches
2021-08-13 18:59 ` Simon Marchi via Gdb-patches
2021-08-13 22:15 ` Patrick Monnerat via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa262ca5-ddbc-80a9-e564-40e3e5093bcb@monnerat.net \
--to=gdb-patches@sourceware.org \
--cc=patrick@monnerat.net \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox