From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GAmHOTtgGGFZTgAAWB0awg (envelope-from ) for ; Sat, 14 Aug 2021 20:30:51 -0400 Received: by simark.ca (Postfix, from userid 112) id E93C81EDFB; Sat, 14 Aug 2021 20:30:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ACF9C1E813 for ; Sat, 14 Aug 2021 20:30:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1AA133865C2D for ; Sun, 15 Aug 2021 00:30:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AA133865C2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628987450; bh=YzJ/lVIILXEXGr6pgMxjiY1BJ0niLRxpjB5lqs14iew=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=nkcAvMGPZMIvJwIcBESnF2euvKw0o9bNrlcQKGjfqHqInbO0w9IMCESKa5TG2l6vZ hcQJvgQNQR/wQ/sGsWc8M5HhYTz7QctKrQAT9OQuNlg2SfTVO3SouSaaF4U7GMBklg q6lzDSiYLLir8KC0Y65orl16tyxtsF9t2Z6wOjhU= Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id 7B01F3853838 for ; Sun, 15 Aug 2021 00:30:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B01F3853838 Received: from patrick.monnerat ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 17F0U2Hv012976 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Aug 2021 02:30:07 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 17F0U2Hv012976 Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling To: Simon Marchi , gdb-patches@sourceware.org References: <20210813222411.3076-1-patrick@monnerat.net> <3002b4db-52a4-b7a5-ca1a-49398ba439ed@polymtl.ca> Message-ID: Date: Sun, 15 Aug 2021 02:30:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3002b4db-52a4-b7a5-ca1a-49398ba439ed@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Patrick Monnerat via Gdb-patches Reply-To: Patrick Monnerat Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 8/14/21 6:05 AM, Simon Marchi wrote: > I looked at the change a bit more in depth, in particular at the various > observers of breakpoint_modified. One of them is MI, who prints the > =breakpoint-modified notification. Good catch ! > if I run a program with a breakpoint with "enable > count 1 1", the notification I get without your patch is: > > =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="n",... > ^ > And with the patch: > > =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="y", > ^ You probably mean the other way round... Next patch post will contain tests according to your advices. Many thanks for your hints and your work on this. Patrick