From: Patrick Monnerat via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] Notify observer of breakpoint auto-disabling
Date: Fri, 13 Aug 2021 17:31:31 +0200 [thread overview]
Message-ID: <20210813153131.54709-1-patrick@monnerat.net> (raw)
As observer in currently notified of breakpoint stop before handling its
auto-disabling after count is reached, the observer is never notified of
the disabling.
This patch moves the observer notification after the auto-disabling
code.
Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336
* gdb/breakpoint.c (bpstat_stop_status): move observer notification
after auto-disabling code.
---
gdb/breakpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 89af44ee4c6..feca224ccf4 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5491,7 +5491,6 @@ bpstat_stop_status (const address_space *aspace,
if (bs->stop)
{
++(b->hit_count);
- gdb::observers::breakpoint_modified.notify (b);
/* We will stop here. */
if (b->disposition == disp_disable)
@@ -5501,6 +5500,7 @@ bpstat_stop_status (const address_space *aspace,
b->enable_state = bp_disabled;
removed_any = 1;
}
+ gdb::observers::breakpoint_modified.notify (b);
if (b->silent)
bs->print = 0;
bs->commands = b->commands;
--
2.31.1
next reply other threads:[~2021-08-13 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 15:31 Patrick Monnerat via Gdb-patches [this message]
2021-08-13 15:45 ` Simon Marchi via Gdb-patches
2021-08-13 16:27 ` Patrick Monnerat via Gdb-patches
2021-08-13 18:59 ` Simon Marchi via Gdb-patches
2021-08-13 22:15 ` Patrick Monnerat via Gdb-patches
2021-08-13 22:24 Patrick Monnerat via Gdb-patches
2021-08-14 4:05 ` Simon Marchi via Gdb-patches
2021-08-15 0:30 ` Patrick Monnerat via Gdb-patches
2021-08-15 0:33 Patrick Monnerat via Gdb-patches
2021-08-16 1:32 ` Simon Marchi via Gdb-patches
2021-08-16 12:44 Patrick Monnerat via Gdb-patches
2021-08-16 14:04 ` Simon Marchi via Gdb-patches
2021-08-16 14:09 ` Patrick Monnerat via Gdb-patches
2021-08-16 15:10 ` Simon Marchi via Gdb-patches
2021-08-16 16:18 ` Patrick Monnerat via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813153131.54709-1-patrick@monnerat.net \
--to=gdb-patches@sourceware.org \
--cc=patrick@monnerat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox