From: Alan Modra <amodra@gmail.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PING][PATCH] binutils-gdb/git: Handle *.ac and *.m4 files in .gitattributes
Date: Thu, 18 Dec 2025 10:48:25 +1030 [thread overview]
Message-ID: <aUNIUSsymi4uxjxJ@squeak.grove.modra.org> (raw)
In-Reply-To: <93deb8ec-db69-425a-9a56-30f802363b1b@suse.de>
On Wed, Dec 17, 2025 at 10:25:24PM +0100, Tom de Vries wrote:
> On 12/3/25 9:51 AM, Tom de Vries wrote:
> > Since commit 52ca3d3fe61 ("toplevel: unify the GCC and GDB/binutils .editorconfig
> > files"), .editorconfig has settings for .ac and .m4 files:
> > ...
> > [*.{ac,m4}]
> > indent_style = tab
> > indent_size = 2
> > trim_trailing_whitespace = true
> > ...
> >
> > There are no setting for those files in .gitattributes, so the whitespace
> > attribute defaults to trailing-space (shorthand for blank-at-eol,
> > blank-at-eof) and space-before-tab.
> >
> > Since according to .editorconfig the indentation style is tab, add
> > indent-with-non-tab as well.
> >
> > Since aclocal.m4 is generated, unset the whitespace attribute. Likewise for
> > configure.
>
> Ping.
I'll rubber-stamp this for the binutils side, but IMO there is no need
for a global gdb maintainer to wait for approval from binutils
maintainers for this shared file.
--
Alan Modra
next prev parent reply other threads:[~2025-12-18 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 8:51 [PATCH] " Tom de Vries
2025-12-04 16:32 ` Tom Tromey
2025-12-17 21:25 ` [PING][PATCH] " Tom de Vries
2025-12-18 0:18 ` Alan Modra [this message]
2025-12-30 22:54 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUNIUSsymi4uxjxJ@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox