From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] binutils-gdb/git: Handle *.ac and *.m4 files in .gitattributes
Date: Thu, 04 Dec 2025 09:32:23 -0700 [thread overview]
Message-ID: <87wm325ht4.fsf@tromey.com> (raw)
In-Reply-To: <20251203085111.3655102-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 3 Dec 2025 09:51:11 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Since commit 52ca3d3fe61 ("toplevel: unify the GCC and GDB/binutils .editorconfig
Tom> files"), .editorconfig has settings for .ac and .m4 files:
Tom> ...
Tom> [*.{ac,m4}]
Tom> indent_style = tab
Tom> indent_size = 2
Tom> trim_trailing_whitespace = true
Tom> ...
Tom> There are no setting for those files in .gitattributes, so the whitespace
Tom> attribute defaults to trailing-space (shorthand for blank-at-eol,
Tom> blank-at-eof) and space-before-tab.
Tom> Since according to .editorconfig the indentation style is tab, add
Tom> indent-with-non-tab as well.
Tom> Since aclocal.m4 is generated, unset the whitespace attribute. Likewise for
Tom> configure.
FWIW this seems fine to me.
Tom
next prev parent reply other threads:[~2025-12-04 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 8:51 Tom de Vries
2025-12-04 16:32 ` Tom Tromey [this message]
2025-12-17 21:25 ` [PING][PATCH] " Tom de Vries
2025-12-18 0:18 ` Alan Modra
2025-12-30 22:54 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm325ht4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox